Re: [elpa] master 9ef4325: * debbugs-gnu.el (debbugs-gnu--parse-mail): Pacify byte compiler.

Re: [elpa] master 9ef4325: * debbugs-gnu.el (debbugs-gnu--parse-mail): Pacify byte compiler.

[Stefan Monnier]

> diff --git a/packages/debbugs/debbugs-gnu.el b/packages/debbugs/debbugs-gnu.el
> index 5084b61..ceddc00 100644
> --- a/packages/debbugs/debbugs-gnu.el
> +++ b/packages/debbugs/debbugs-gnu.el
> @@ -2680,6 +2680,9 @@ If SELECTIVELY, query the user before applying the patch."
>  (defun debbugs-gnu--parse-mail (string)
>    (let* ((mail-extr-ignore-single-names nil)
>  	 (mail-extr-ignore-realname-equals-mailbox-name nil))
> +    ;; Pacify byte compiler.
> +    (ignore
> +     mail-extr-ignore-single-names mail-extr-ignore-realname-equals-mailbox-name)
>      (mail-extract-address-components string)))
>
I suspect this is wrong because the warnings here reflects a real bug.
The bug is that those variables should not be bound lexically but
dynamically, so the real fix is to add

    (defvar mail-extr-ignore-single-names)
    (defvar mail-extr-ignore-realname-equals-mailbox-name)

somewhere earlier, or to `require` the package which defines those two vars.


        Stefan

Re: [elpa] master 9ef4325: * debbugs-gnu.el (debbugs-gnu--parse-mail): Pacify byte compiler.

[Michael Albinus]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> I suspect this is wrong because the warnings here reflects a real bug.
> The bug is that those variables should not be bound lexically but
> dynamically, so the real fix is to add
>
>     (defvar mail-extr-ignore-single-names)
>     (defvar mail-extr-ignore-realname-equals-mailbox-name)
>
> somewhere earlier, or to `require` the package which defines those two vars.

Hmm, you're right. Fixed.

>         Stefan

Best regards, Michael.