From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: emacs-devel@gnu.org
Subject: Re: [elpa] master 9ef4325: * debbugs-gnu.el (debbugs-gnu--parse-mail): Pacify byte compiler.
Date: Sun, 11 Oct 2020 09:27:19 -0400 [thread overview]
Message-ID: <jwvlfgcevyx.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <20201011083737.0D1FC20667@vcs0.savannah.gnu.org> (Michael Albinus's message of "Sun, 11 Oct 2020 04:37:36 -0400 (EDT)")
> diff --git a/packages/debbugs/debbugs-gnu.el b/packages/debbugs/debbugs-gnu.el
> index 5084b61..ceddc00 100644
> --- a/packages/debbugs/debbugs-gnu.el
> +++ b/packages/debbugs/debbugs-gnu.el
> @@ -2680,6 +2680,9 @@ If SELECTIVELY, query the user before applying the patch."
> (defun debbugs-gnu--parse-mail (string)
> (let* ((mail-extr-ignore-single-names nil)
> (mail-extr-ignore-realname-equals-mailbox-name nil))
> + ;; Pacify byte compiler.
> + (ignore
> + mail-extr-ignore-single-names mail-extr-ignore-realname-equals-mailbox-name)
> (mail-extract-address-components string)))
>
I suspect this is wrong because the warnings here reflects a real bug.
The bug is that those variables should not be bound lexically but
dynamically, so the real fix is to add
(defvar mail-extr-ignore-single-names)
(defvar mail-extr-ignore-realname-equals-mailbox-name)
somewhere earlier, or to `require` the package which defines those two vars.
Stefan
next parent reply other threads:[~2020-10-11 13:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20201011083736.5056.91918@vcs0.savannah.gnu.org>
[not found] ` <20201011083737.0D1FC20667@vcs0.savannah.gnu.org>
2020-10-11 13:27 ` Stefan Monnier [this message]
2020-10-11 13:42 ` [elpa] master 9ef4325: * debbugs-gnu.el (debbugs-gnu--parse-mail): Pacify byte compiler Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvlfgcevyx.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.