Re: master 62233c9: Use lexical-binding in lisp/{term,nxml,language}

Re: master 62233c9: Use lexical-binding in lisp/{term,nxml,language}

[Michael Albinus]

monnier@iro.umontreal.ca (Stefan Monnier) writes:

Hi Stefan,

> branch: master
> commit 62233c9824047e989cb72c8e2d05e4b4444fe0be
> Author: Stefan Monnier <monnier@iro.umontreal.ca>
> Commit: Stefan Monnier <monnier@iro.umontreal.ca>
>
>     Use lexical-binding in lisp/{term,nxml,language}
>
>     * test/lisp/electric-tests.el:
>     * lisp/term/w32console.el:
>     * lisp/nxml/rng-util.el:
>     * leim/leim-ext.el: Use lexical-binding.
>
>     * lisp/international/titdic-cnv.el (tit-process-header)
>     (miscdic-convert):
>     * lisp/international/mule-cmds.el (leim-list-header):
>     * lisp/international/ja-dic-cnv.el (skkdic-convert):
>     Use lexical-binding in the generated file.
> ---
>  leim/leim-ext.el                 | 12 ++++++------
>  lisp/international/ja-dic-cnv.el |  3 ++-
>  lisp/international/mule-cmds.el  |  2 +-
>  lisp/international/quail.el      |  2 +-
>  lisp/international/titdic-cnv.el |  4 ++++
>  lisp/nxml/rng-util.el            |  2 +-
>  lisp/term/w32console.el          |  2 +-
>  test/lisp/electric-tests.el      |  2 +-
>  8 files changed, 17 insertions(+), 12 deletions(-)

Looks, like this has broken electric-tests :-(

Best regards, Michael.

Re: master 62233c9: Use lexical-binding in lisp/{term,nxml,language}

[Stefan Monnier]

>> commit 62233c9824047e989cb72c8e2d05e4b4444fe0be
[...]
> Looks, like this has broken electric-tests :-(

What makes you think so?  `make check` gives me no failures.


        Stefan

Re: master 62233c9: Use lexical-binding in lisp/{term,nxml,language}

[Michael Albinus]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

Hi Stefan,

>>> commit 62233c9824047e989cb72c8e2d05e4b4444fe0be
> [...]
>> Looks, like this has broken electric-tests :-(
>
> What makes you think so?  `make check` gives me no failures.

# make -C test electric-tests

Ran 478 tests, 90 results as expected, 388 unexpected (2021-01-29 21:08:21+0100, 116.476883 sec)

>         Stefan

Best regards, Michael.

Re: master 62233c9: Use lexical-binding in lisp/{term,nxml,language}

[Stefan Monnier]

>> What makes you think so?  `make check` gives me no failures.
> # make -C test electric-tests

Aha!

> Ran 478 tests, 90 results as expected, 388 unexpected (2021-01-29 21:08:21+0100, 116.476883 sec)

Should be fixed now, thanks,


        Stefan

Re: master 62233c9: Use lexical-binding in lisp/{term,nxml,language}

[Stefan Kangas]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>>> commit 62233c9824047e989cb72c8e2d05e4b4444fe0be
> [...]
>> Looks, like this has broken electric-tests :-(
>
> What makes you think so?  `make check` gives me no failures.

I think you need to say:

    make -C test electric-tests

I see many failures like the following:

    Test electric-pair-angle-brackets-everywhere-2-at-point-2-in-js-mode
backtrace:
      (closure ((test-in-code . t) (test-in-strings . t) (test-in-comments
      (electric-pair-test-for "(<>" 2 60 "(<><>" 3 'js-mode '((electric-pa
      (closure (t) nil (electric-pair-test-for "(<>" 2 60 "(<><>" 3 'js-mo
      ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
      ert-run-test(#s(ert-test :name electric-pair-angle-brackets-everywhe
      ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
      ert-run-tests((not (tag :unstable)) #f(compiled-function (event-type
      ert-run-tests-batch((not (tag :unstable)))
      ert-run-tests-batch-and-exit((not (tag :unstable)))
      eval((ert-run-tests-batch-and-exit '(not (tag :unstable))) t)
      command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/electric-tests.el" "
      command-line()
      normal-top-level()
    Test electric-pair-angle-brackets-everywhere-2-at-point-2-in-js-mode
condition:
        (void-function closure)
       FAILED    7/478
electric-pair-angle-brackets-everywhere-2-at-point-2-in-js-mode
(0.000086 sec)