From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [elpa] main 2ec80977e1: * elpa-packages (dired-preview): New package Date: Mon, 10 Jul 2023 17:13:54 -0400 Message-ID: References: <168884609732.27984.6450580686777461843@vcs2.savannah.gnu.org> <20230708195457.95F1AC11DD8@vcs2.savannah.gnu.org> <87zg43iprw.fsf@posteo.net> <87edlfbjsx.fsf@protesilaos.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32245"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Philip Kaludercic , emacs-devel@gnu.org To: Protesilaos Stavrou Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jul 10 23:14:38 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qIyDN-00088y-JH for ged-emacs-devel@m.gmane-mx.org; Mon, 10 Jul 2023 23:14:37 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qIyCp-00055O-QV; Mon, 10 Jul 2023 17:14:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qIyCm-000556-Ue for emacs-devel@gnu.org; Mon, 10 Jul 2023 17:14:01 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qIyCl-0005Cq-80 for emacs-devel@gnu.org; Mon, 10 Jul 2023 17:14:00 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 26BAF805E6; Mon, 10 Jul 2023 17:13:56 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 0062C80057; Mon, 10 Jul 2023 17:13:55 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1689023635; bh=XNRSqhuyqvs/dMHcOiP4h7vLlNyoIDNKps28DOzQOl0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=EfOun5kZ9QA3wV9G8+BaYrN+tflZRlpCwP5v8FJ4rYOJfCn9aBRVh3N9gerUnCW4s uElyzQH6MitPXPaagV8PDAlOEa+2kWyMFsz6+HtZjswDgNhhiNy5h1HIL+eLk0bRyH NvzRLf/rQ63H+I8ApZWH8HdWm2FreMHTm2H5fU9gNhddDXVtEO2y1rc+uDGVXzyh6U 9GpXE9lDtK7FEbywdD5j/gjW/KIm6uHM1BD/QsDUHXlnoScF0zIucTiCh0Nu/VAF9s tfJnQScBNuTubn1PB7yq93SDnj5ABrkxBBrtdqMHojZGHTCINgVPKvdZacwuoQLYxr 1nD52rRnK27RA== Original-Received: from pastel (unknown [24.140.234.50]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id CF20112032C; Mon, 10 Jul 2023 17:13:54 -0400 (EDT) In-Reply-To: <87edlfbjsx.fsf@protesilaos.com> (Protesilaos Stavrou's message of "Mon, 10 Jul 2023 23:20:14 +0300") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:307735 Archived-At: >> - (when (and (bufferp buffer) >> - (buffer-live-p buffer)) >> - buffer)) >> + (and (bufferp buffer) >> + (buffer-live-p buffer))) >> dired-preview--buffers)) > > This is technically correct but more difficult to express intent. BTW, `buffer-live-p` also accepts non-buffer arguments, so you can skip the `bufferp` test. >> (let ((size 0)) >> - (mapc >> - (lambda (buffer) >> - (setq size (+ (buffer-size buffer) size))) >> - (dired-preview--get-buffers)) >> + (dolist (buffer (dired-preview--get-buffers)) >> + (setq size (+ (buffer-size buffer) size))) >> size)) > > Since we are here, what is the technical advantage of dolist over mapc? > I have searched the docs for a clarification, but have not found one. I > get that it looks tidier, but is there a performance boost or something? It's like an inlined mapc, which makes it a bit more efficient, yes. Stefan