From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#67180: 30.0.50; 'pp-to-string' emits extra newline Date: Thu, 16 Nov 2023 09:16:02 -0500 Message-ID: References: <83il63rzrt.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23527"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 67180@debbugs.gnu.org, Eli Zaretskii To: Eshel Yaron Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 16 15:17:21 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r3dBH-0005n9-UI for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 16 Nov 2023 15:17:20 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r3dB2-0005So-SR; Thu, 16 Nov 2023 09:17:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r3dB1-0005Sc-8t for bug-gnu-emacs@gnu.org; Thu, 16 Nov 2023 09:17:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r3dB1-00008l-0h for bug-gnu-emacs@gnu.org; Thu, 16 Nov 2023 09:17:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r3dB0-0004oD-HB for bug-gnu-emacs@gnu.org; Thu, 16 Nov 2023 09:17:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 16 Nov 2023 14:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67180 X-GNU-PR-Package: emacs Original-Received: via spool by 67180-submit@debbugs.gnu.org id=B67180.170014418818435 (code B ref 67180); Thu, 16 Nov 2023 14:17:02 +0000 Original-Received: (at 67180) by debbugs.gnu.org; 16 Nov 2023 14:16:28 +0000 Original-Received: from localhost ([127.0.0.1]:54829 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3dAR-0004nH-TA for submit@debbugs.gnu.org; Thu, 16 Nov 2023 09:16:28 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:32845) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3dAM-0004mx-G5 for 67180@debbugs.gnu.org; Thu, 16 Nov 2023 09:16:26 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 61A8944231E; Thu, 16 Nov 2023 09:16:17 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1700144176; bh=iKI+TsgVeg7ghQUapUKimBam1+oA0y3fUZAjrERCPcI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=OIH/7uxuvtvs7fGkbEuBKLEZ45ZCUKjHApdvb5/iJlBRIW/SVgaYAeck023V2XV2n 8p7sm5NTyfoNlRYV7u/6tHNOfHPqfCah6T6fVcRy3oXgRxjkWrCkZ0PspIk6l+uqLu CuT9JlQ71oe33uGL/aUrXsUJOIjxXPYu5TM2v/tqDhOGg18OzOQuVJbePUtogwn9Ah zA38eJlh9k/JqhrgUH0gtG0l8Zp2Zok/aGE1pCxDcJ/a9mb7lZVSE2slr7N8gcXWyh eHIlvjnnQp+uHYMXP+hlxVzncicxtajVyoGdSKeT21UcCZTUyB1XfTbWgkBiyAFmgR kxmslxQ7ZLD0g== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 5965D441158; Thu, 16 Nov 2023 09:16:16 -0500 (EST) Original-Received: from pastel (unknown [45.72.227.120]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 2D9C31201B4; Thu, 16 Nov 2023 09:16:16 -0500 (EST) In-Reply-To: (Eshel Yaron's message of "Wed, 15 Nov 2023 14:10:39 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:274455 Archived-At: Eshel Yaron [2023-11-15 14:10:39] wrote: > Stefan Monnier writes: > >>>> On Emacs 29 and earlier, with `-Q`, we have: >>>> >>>> (pp-to-string "foo") >>>> => "\"foo\"" >>>> >>>> On master with `-Q`, we get an extra newline at the end of the string: >>>> >>>> (pp-to-string "foo") >>>> => "\"foo\" >>>> " >> >> Is that a problem? > > FWIW, I think that this change is for the better, but it is > incompatible, and sadly it broke `agda2-mode`. (In some sense this > probably Agda's "fault", because I don't really understand why they're > using `pp-to-string` the way they do.) My suggestion was simply to > explicitly mention this new behavior in NEWS or some such. Like this? diff --git a/etc/NEWS b/etc/NEWS index 23f4a8b5311..2dcb2f5664e 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -1099,6 +1099,9 @@ showcases all their customization options. * Incompatible Lisp Changes in Emacs 30.1 +** 'pp' and 'pp-to-string' now always include a terminating newline. +In the past they included a terminating newline in most cases but not all. + ** 'buffer-match-p' and 'match-buffers' take '&rest args'. They used to take a single '&optional arg' and were documented to use an unreliable hack to try and support condition predicates that -- Stefan