From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Alan Mackenzie <acm@muc.de>
Cc: 67196@debbugs.gnu.org, Eli Zaretskii <eliz@gnu.org>
Subject: bug#67196: M-: uses a wrong value of debug-on-error when it is nil.
Date: Fri, 24 Nov 2023 16:25:11 -0500 [thread overview]
Message-ID: <jwvleam6e7v.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <ZWENlc6fj9odIdt6@ACM> (Alan Mackenzie's message of "Fri, 24 Nov 2023 20:54:45 +0000")
> + (let* ((debug-from--eval-expression eval-expression-debug-on-error)
> + (result (values--store-value
> + (eval (let ((lexical-binding t)) (macroexpand-all exp)) t)))
> + (print-length (unless no-truncate eval-expression-print-length))
> + (print-level (unless no-truncate eval-expression-print-level))
> + (eval-expression-print-maximum-character char-print-limit)
> + (deactivate-mark)
> + (out (if insert-value (current-buffer) t)))
> + (prog1
> + (prin1 result out)
> + (let ((str (and char-print-limit
> + (eval-expression-print-format result))))
> + (when str (princ str out))))))
So you kicked the can a bit further down the road.
The next bug report will be that `M-: debug-from--eval-expression` does
not return the expected value.
FWIW, the other way I came up to circumvent the problem is to test the
shape of the expression to evaluate and only use
`eval-expression-debug-on-error` when the expression is not a mere
symbol (for which the backtrace would presumably not be interesting anyway).
But then we get the weird situation where `M-x debug-on-error` can
return nil but `M-x (list debug-on-error ...)` returns a list that
starts with t.
I think I'd rather keep the current code, whose semantics is
actually simpler.
Stefan
next prev parent reply other threads:[~2023-11-24 21:25 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-15 13:48 bug#67196: M-: uses a wrong value of debug-on-error when it is nil Alan Mackenzie
2023-11-15 17:19 ` Eli Zaretskii
2023-11-15 17:55 ` Alan Mackenzie
2023-11-19 17:19 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-19 17:33 ` Eli Zaretskii
[not found] ` <87a5r9efj0.fsf@dick>
2023-11-19 19:30 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-24 17:10 ` Alan Mackenzie
2023-11-24 18:48 ` Eli Zaretskii
2023-11-24 20:54 ` Alan Mackenzie
2023-11-24 21:25 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-11-24 22:21 ` Alan Mackenzie
2023-11-25 7:59 ` Eli Zaretskii
2023-11-25 10:32 ` Alan Mackenzie
2023-11-25 11:15 ` Eli Zaretskii
2023-11-25 12:40 ` Alan Mackenzie
2023-11-25 13:04 ` Eli Zaretskii
2023-11-25 14:14 ` Alan Mackenzie
2023-11-25 15:50 ` Eli Zaretskii
2023-11-25 16:40 ` Alan Mackenzie
2023-11-25 16:46 ` Eli Zaretskii
2023-11-25 16:57 ` Alan Mackenzie
2023-11-25 17:36 ` Alan Mackenzie
2023-11-25 18:12 ` Andreas Schwab
2023-11-25 14:23 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-17 4:23 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-19 3:54 ` Richard Stallman
2023-12-19 5:05 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-25 3:41 ` Richard Stallman
2023-12-26 2:39 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-27 4:54 ` Richard Stallman
2023-11-25 7:30 ` Eli Zaretskii
2023-11-24 20:22 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvleam6e7v.fsf-monnier+emacs@gnu.org \
--to=bug-gnu-emacs@gnu.org \
--cc=67196@debbugs.gnu.org \
--cc=acm@muc.de \
--cc=eliz@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.