From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#67005: 30.0.50; improve nadivce/comp/trampoline handling Date: Sat, 25 Nov 2023 09:39:42 -0500 Message-ID: References: <874jhv9921.fsf@sappc2.fritz.box> <875y24zrt1.fsf@sappc2.fritz.box> <87ttpmwuxi.fsf@sappc2.fritz.box> <877cmct4a1.fsf@sappc2.fritz.box> <87bkbmiwpf.fsf@sappc2.fritz.box> <87leap8n1z.fsf@sappc2.fritz.box> <87leaob192.fsf@sappc2.fritz.box> <871qcegg43.fsf@sappc2.fritz.box> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15481"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Andrea Corallo , 67005@debbugs.gnu.org To: Jens Schmidt Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 25 15:40:18 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r6tpR-0003rO-Qf for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 Nov 2023 15:40:18 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r6tpA-0005ra-G6; Sat, 25 Nov 2023 09:40:00 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r6tp7-0005r8-Jo for bug-gnu-emacs@gnu.org; Sat, 25 Nov 2023 09:39:57 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r6tp7-00087v-BQ for bug-gnu-emacs@gnu.org; Sat, 25 Nov 2023 09:39:57 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r6tpC-0001Ni-CH for bug-gnu-emacs@gnu.org; Sat, 25 Nov 2023 09:40:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 Nov 2023 14:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67005 X-GNU-PR-Package: emacs Original-Received: via spool by 67005-submit@debbugs.gnu.org id=B67005.17009231975295 (code B ref 67005); Sat, 25 Nov 2023 14:40:02 +0000 Original-Received: (at 67005) by debbugs.gnu.org; 25 Nov 2023 14:39:57 +0000 Original-Received: from localhost ([127.0.0.1]:38252 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r6tp7-0001NK-GP for submit@debbugs.gnu.org; Sat, 25 Nov 2023 09:39:57 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:20412) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r6tp5-0001N7-Fq for 67005@debbugs.gnu.org; Sat, 25 Nov 2023 09:39:55 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id E48E144187A; Sat, 25 Nov 2023 09:39:44 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1700923183; bh=xC/GzQxai4nu8mL135u8/em7qwn//FldwgqrBXXr8b0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=BBcVcxdefLRVMKhKTmUEuUdeohzVsq+8ooZs9N7cEcB6hB13G95L9pmgHAAdZAqBk slqjhjQgDPa1+V/0qvarU2XmTv1GFRDRXy51OkJC5eXipXdpehOtHILCHRpG6m5z2z N4IGyrRKPTkn+/E1rrabFxB8j1mmUMTh8wcIYstfcwxr4MvQfFEF15Qs2z8zgWB9ya Eq/FYuaPhC7gAQXqQ9B2cK0pIa79iSrpsZ/e51BmQ/bqPrb1rhmTb6KtJHaH1BP8d9 RXXYfnBPeJU4aTRWUJr+4JxxdMMevC4Jz4ioaBxaDPcQ6RW/CTyrtCKYorZvO/g+AZ xeACR3D513TlA== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id E6E52441518; Sat, 25 Nov 2023 09:39:43 -0500 (EST) Original-Received: from pastel (unknown [45.72.227.120]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id BD699120210; Sat, 25 Nov 2023 09:39:43 -0500 (EST) In-Reply-To: <871qcegg43.fsf@sappc2.fritz.box> (Jens Schmidt's message of "Sat, 25 Nov 2023 13:41:16 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:274984 Archived-At: > What about this one? Too indiscrete? > > (when purify-flag > (message "\a\nWarning: Invalid pre-dump advice on %s\n" symbol)) That works. > Plus another idea: Instead of placing the test into `advice-add', how > about checking functions for advices in loadup.el? We could place that > check just before site-load.el gets loaded, to avoid trouble for Emacs > modders. I tried the following, and it seemed to do the trick: > > +(mapatoms > + (lambda (f) > + (and (advice--p (symbol-function f)) > + (error "Pre-dump advice on %s" f)))) Even better! Stefan