From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Jens Schmidt <jschmidt4gnu@vodafonemail.de>
Cc: emacs-devel@gnu.org
Subject: Re: master 3b1fd42732f: * lisp/loadup.el: Check advice after `rmc.el`; turn error into warning
Date: Tue, 12 Dec 2023 18:13:06 -0500 [thread overview]
Message-ID: <jwvle9zf24v.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <73d5b60d-afbd-4543-8001-9fe043b4b6ab@vodafonemail.de> (Jens Schmidt's message of "Tue, 12 Dec 2023 22:48:56 +0100")
> But when I tried to place that advice-checking-code into loadup.el,
> I also saw this rmc.el and didn't quite know what to do with it. I
> thought that Lars might have placed it *inadvertently* after the
>
> (load "site-load" t)
>
> block, because, um, logically it belongs to before that, doesn't it?
That was also my impression, indeed.
> So probably TRT here would be to place these paragraphs as follows:
>
> 0. (load "leim/leim-list.el" t)
>
> 1. (load "emacs-lisp/rmc")
>
> 2. Check for advices (on core libs only).
>
> 3. (load "site-load" t)
>
> 4. "default-directory must be unibyte"
>
> What do you think?
I decided that it was OK to keep "check for advice" after loading
`site-load` now that it's a warning. IOW I don't have a strong opinion
on the order between `2` and `3`.
But I agree that `rmc` should come before those two.
Stefan
next prev parent reply other threads:[~2023-12-12 23:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <170197287539.12661.7539324399514249195@vcs2.savannah.gnu.org>
[not found] ` <20231207181435.BCB79C0C6AD@vcs2.savannah.gnu.org>
2023-12-12 21:48 ` master 3b1fd42732f: * lisp/loadup.el: Check advice after `rmc.el`; turn error into warning Jens Schmidt
2023-12-12 23:13 ` Stefan Monnier [this message]
2023-12-13 11:46 ` Eli Zaretskii
2023-12-13 23:03 ` Jens Schmidt
2023-12-14 7:23 ` Eli Zaretskii
2023-12-14 20:03 ` Jens Schmidt
2023-12-14 20:27 ` Eli Zaretskii
2023-12-14 21:21 ` Jens Schmidt
2023-12-16 13:07 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvle9zf24v.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=jschmidt4gnu@vodafonemail.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.