From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Should `cancel-timer' use `delete' instead of `delq'? Date: Tue, 05 Sep 2006 11:38:50 -0400 Message-ID: References: <87zmdfytmw.fsf@catnip.gol.com> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1157470805 20949 80.91.229.2 (5 Sep 2006 15:40:05 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 5 Sep 2006 15:40:05 +0000 (UTC) Cc: Drew Adams , Emacs-Devel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Sep 05 17:40:02 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1GKd1G-0000es-8r for ged-emacs-devel@m.gmane.org; Tue, 05 Sep 2006 17:39:23 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GKd1E-0004Sg-TY for ged-emacs-devel@m.gmane.org; Tue, 05 Sep 2006 11:39:20 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1GKd0x-0004PV-1L for emacs-devel@gnu.org; Tue, 05 Sep 2006 11:39:03 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1GKd0w-0004P9-CT for emacs-devel@gnu.org; Tue, 05 Sep 2006 11:39:02 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GKd0w-0004P3-7n for emacs-devel@gnu.org; Tue, 05 Sep 2006 11:39:02 -0400 Original-Received: from [132.204.24.67] (helo=mercure.iro.umontreal.ca) by monty-python.gnu.org with esmtp (Exim 4.52) id 1GKdBg-0007HP-C7; Tue, 05 Sep 2006 11:50:08 -0400 Original-Received: from hidalgo.iro.umontreal.ca (hidalgo.iro.umontreal.ca [132.204.27.50]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id 05F622CEB99; Tue, 5 Sep 2006 11:39:00 -0400 (EDT) Original-Received: from faina.iro.umontreal.ca (faina.iro.umontreal.ca [132.204.26.177]) by hidalgo.iro.umontreal.ca (Postfix) with ESMTP id A14CE3FE0; Tue, 5 Sep 2006 11:38:50 -0400 (EDT) Original-Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id 7F0DD6C7F5; Tue, 5 Sep 2006 11:38:50 -0400 (EDT) Original-To: Miles Bader In-Reply-To: <87zmdfytmw.fsf@catnip.gol.com> (Miles Bader's message of "Tue, 05 Sep 2006 10:44:23 +0900") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-2.82, requis 5, autolearn=not spam, ALL_TRUSTED -2.82) X-DIRO-MailScanner-From: monnier@iro.umontreal.ca X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:59378 Archived-At: > It's almost certainly intentional that it uses delq. A timer is a > unique entity. > If application code can create multiple timers and doesn't save all the > corresponding cookies for deletion, it's obviously a bug in that > application code. While I somewhat agree with Miles, I also agree with Drew that it can lead to undesirable situations where it's very difficult to return to a "normal" session, other than by restarting Emacs. I've been tempted to change timer-idle-list and timer-list so that they use weak-pointers. I.e. if you don't hold on to your timer by storing it in a global var or somesuch, then it'll get cancelled/destroyed at the next GC. I think this could work if we only do it for timers that use `repeat'. Stefan