all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: "Juanma Barranquero" <lekktu@gmail.com>
Cc: "山本和彦 Kazu Yamamoto" <kazu@iij.ad.jp>, emacs-devel@gnu.org
Subject: Re: unused local variables
Date: Fri, 30 Nov 2007 10:10:31 -0500	[thread overview]
Message-ID: <jwvk5nz3hao.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <f7ccd24b0711300137s49de9416ka2ac10116aca8448@mail.gmail.com> (Juanma Barranquero's message of "Fri, 30 Nov 2007 10:37:55 +0100")

> Are you saying that in

>  (defun test ()
>    (if my-dynamic-var
>        "correct"
>      "erroneous"))

>  (let ((my-dynamic-var t))
>    (test))

> you would force my-dynamic-var to be `defvar'ed to avoid a warning in the let?

Yes.  And that's good.  E.g. if you want to compile this file with the
lexical-scoping version of Emacs that Miles has been working on, this
is indispensable.

BTW, in the above example, the byte-compiler already complains in the
`test' function, so it's not like it's going to make that big
a difference.

Also dynamic scoping is sufficiently odd and rarely used that it deserve
special mention in the code.  It's pretty common to mark it with
a comment.  And code is always better than a comment since it tends to
bitrot a bit less quickly.


        Stefan


PS: Another "unused var" warning which we should add (I don't have it
    in my lock hack yet, tho) is the one that notices when a `defvar'
    declares a variable which is not used in the file.

  parent reply	other threads:[~2007-11-30 15:10 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-29 12:32 unused local variables Kazu Yamamoto
2007-11-29 15:31 ` Thien-Thi Nguyen
2007-11-30  0:23   ` Kazu Yamamoto
2007-11-30  9:22     ` Juanma Barranquero
2007-11-30  9:27       ` Kazu Yamamoto
2007-11-30  9:37         ` Juanma Barranquero
2007-11-30  9:59           ` David Kastrup
2007-11-30 10:14             ` Juanma Barranquero
2007-11-30 10:23               ` David Kastrup
2007-11-30 10:26                 ` Juanma Barranquero
2007-11-30 10:36                   ` David Kastrup
2007-11-30 10:49                     ` Juanma Barranquero
2007-11-30 10:34           ` Kazu Yamamoto
2007-11-30 10:45             ` Juanma Barranquero
2007-11-30 11:26               ` David Kastrup
2007-11-30 11:39                 ` Juanma Barranquero
2007-12-03  2:30               ` Kazu Yamamoto
2007-12-03  9:50                 ` Juanma Barranquero
2007-12-03 10:03                   ` Kazu Yamamoto
2007-11-30 15:10           ` Stefan Monnier [this message]
2007-11-30 15:31             ` Juanma Barranquero
2007-11-30 15:58               ` Stefan Monnier
2007-11-30 16:40                 ` David Kastrup
2007-11-30 17:58                   ` tomas
2007-11-30 18:07                 ` Juanma Barranquero
2007-11-30 15:38             ` Juanma Barranquero
2007-11-30 15:59               ` Stefan Monnier
2007-11-30 18:11                 ` Juanma Barranquero
2007-12-01  3:17                   ` Stefan Monnier
2007-11-29 16:02 ` Stefan Monnier
2007-11-30  0:25   ` Kazu Yamamoto
2007-12-04 11:12 ` Katsumi Yamaoka
2007-12-04 15:28   ` Dan Nicolaescu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvk5nz3hao.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=kazu@iij.ad.jp \
    --cc=lekktu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.