rename-buffer and ido-everythwere

rename-buffer and ido-everythwere

[William Xu]

When ido-everythwere is turned on, M-x rename-buffer now would prompt up
a list of opened buffers for selection, which is awkward. I think the
old behavior that prompts nothing is a lot better.

This behavior looks like introduced by this change: 

,----[ src/buffer.c ]
| Revision 1.542 - (view) (download) (as text) (annotate) - [select for diffs]
| Sun Dec 9 23:49:00 2007 UTC (36 hours, 25 minutes ago) by jurta
| Branch: MAIN
| Changes since 1.541: +2 -1 lines
| Diff to previous 1.541
| 
| (Frename_buffer): Change interactive spec from "s" to
| Lisp code that uses `read-buffer' with current buffer as default.
`----

CVSROOT:	/sources/emacs
Module name:	emacs
Changes by:	Juri Linkov <jurta>	07/12/09 23:49:00

Index: buffer.c
===================================================================
RCS file: /sources/emacs/emacs/src/buffer.c,v
retrieving revision 1.541
retrieving revision 1.542
diff -u -b -r1.541 -r1.542
--- buffer.c	28 Nov 2007 04:46:22 -0000	1.541
+++ buffer.c	9 Dec 2007 23:49:00 -0000	1.542
@@ -1169,7 +1169,8 @@
 }
 \f
 DEFUN ("rename-buffer", Frename_buffer, Srename_buffer, 1, 2,
-       "sRename buffer (to new name): \nP",
+       "(list (read-buffer \"Rename buffer (to new name): \" \
+	      (current-buffer)) current-prefix-arg)",
        doc: /* Change current buffer's name to NEWNAME (a string).
 If second arg UNIQUE is nil or omitted, it is an error if a
 buffer named NEWNAME already exists.


-- 
William

http://williamxu.net9.org

Re: rename-buffer and ido-everythwere

[Kim F. Storm]

William Xu <william.xwl@gmail.com> writes:

> When ido-everythwere is turned on, M-x rename-buffer now would prompt up
> a list of opened buffers for selection, which is awkward. I think the
> old behavior that prompts nothing is a lot better.

Does this fix the problem?

(put rename-buffer 'ido 'ignore)

[Sorry I don't have a recent 23.x build to test this myself]

-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk

Re: rename-buffer and ido-everythwere

[William Xu]

storm@cua.dk (Kim F. Storm) writes:

> Does this fix the problem?
>
> (put rename-buffer 'ido 'ignore)

You mean: (put 'rename-buffer 'ido 'ignore) ?

Hm,  it makes no difference.

-- 
William

http://williamxu.net9.org

Re: rename-buffer and ido-everythwere

[Stefan Monnier]

>> When ido-everythwere is turned on, M-x rename-buffer now would prompt up
>> a list of opened buffers for selection, which is awkward. I think the
>> old behavior that prompts nothing is a lot better.

> Does this fix the problem?

> (put rename-buffer 'ido 'ignore)

Maybe a better solution (not specific to ido) is to replace
`read-buffer' with `read-string'.


        Stefan

Re: rename-buffer and ido-everythwere

[Kim F. Storm]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>>> When ido-everythwere is turned on, M-x rename-buffer now would prompt up
>>> a list of opened buffers for selection, which is awkward. I think the
>>> old behavior that prompts nothing is a lot better.
>
>> Does this fix the problem?
>
>> (put rename-buffer 'ido 'ignore)
>
> Maybe a better solution (not specific to ido) is to replace
> `read-buffer' with `read-string'.

Indeed, that makes sense.

-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk

Re: rename-buffer and ido-everythwere

[Juri Linkov]

> Maybe a better solution (not specific to ido) is to replace
> `read-buffer' with `read-string'.

As its documentation says, `read-buffer' is supposed to read an arbitrary
buffer name.  In practice, it seems it can read only a name to switch the
buffer to.

OTOH, `rename-buffer' doesn't need the full functionality of `read-buffer':
buffer name completion and the default name in the prompt are no needed,
but the default accessible via M-n for editing and its history list are
needed, and `read-string' supports this.  Fixed in CVS.

-- 
Juri Linkov
http://www.jurta.org/emacs/