easy-menu subtlety

easy-menu subtlety

[Dan Nicolaescu]

The last 3 lines of this code sequence in lisp/progmodes/verilog-mode.el:

    ("Move"
     ,(if (featurep 'xemacs)
          (progn 
            ["Beginning of function"            verilog-beg-of-defun t]
            ["End of function"                  verilog-end-of-defun t]
            ["Mark function"                    verilog-mark-defun t])
        ["Beginning of function"                beginning-of-defun t]
        ["End of function"                      end-of-defun t]
        ["Mark function"                        mark-defun t])

work fine on emacs-22.1 (and later), but do not work on emacs-21. 
emacs-21 throws an error when loading this file:
   Wrong type argument: listp, ["Mark function" mark-defun t]

Does anyone know how to rewrite that code so that it works both in
emacs-21 and emacs-22?  It's not obvious to me... 

Re: easy-menu subtlety

[Andreas Schwab]

Dan Nicolaescu <dann@ics.uci.edu> writes:

> The last 3 lines of this code sequence in lisp/progmodes/verilog-mode.el:
>
>     ("Move"
>      ,(if (featurep 'xemacs)
>           (progn 
>             ["Beginning of function"            verilog-beg-of-defun t]
>             ["End of function"                  verilog-end-of-defun t]
>             ["Mark function"                    verilog-mark-defun t])
>         ["Beginning of function"                beginning-of-defun t]
>         ["End of function"                      end-of-defun t]
>         ["Mark function"                        mark-defun t])

That looks completely bogus to me.  The result of the evaluation of the
form is a single vector, with the other two just thrown away.  I think
the intention was to write this:

    ("Move"
     ,@(if (featurep 'xemacs)
	   '(["Beginning of function"		verilog-beg-of-defun t]
	     ["End of function"			verilog-end-of-defun t]
	     ["Mark function"			verilog-mark-defun t])
	'(["Beginning of function"		beginning-of-defun t]
	  ["End of function"			end-of-defun t]
	  ["Mark function"			mark-defun t]))

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: easy-menu subtlety

[Dan Nicolaescu]

Andreas Schwab <schwab@suse.de> writes:

  > Dan Nicolaescu <dann@ics.uci.edu> writes:
  > 
  > > The last 3 lines of this code sequence in lisp/progmodes/verilog-mode.el:
  > >
  > >     ("Move"
  > >      ,(if (featurep 'xemacs)
  > >           (progn 
  > >             ["Beginning of function"            verilog-beg-of-defun t]
  > >             ["End of function"                  verilog-end-of-defun t]
  > >             ["Mark function"                    verilog-mark-defun t])
  > >         ["Beginning of function"                beginning-of-defun t]
  > >         ["End of function"                      end-of-defun t]
  > >         ["Mark function"                        mark-defun t])
  > 
  > That looks completely bogus to me.  The result of the evaluation of the
  > form is a single vector, with the other two just thrown away.  I think
  > the intention was to write this:
  > 
  >     ("Move"
  >      ,@(if (featurep 'xemacs)
  > 	   '(["Beginning of function"		verilog-beg-of-defun t]
  > 	     ["End of function"			verilog-end-of-defun t]
  > 	     ["Mark function"			verilog-mark-defun t])
  > 	'(["Beginning of function"		beginning-of-defun t]
  > 	  ["End of function"			end-of-defun t]
  > 	  ["Mark function"			mark-defun t]))

Thanks, but it doesn't work with emacs-21: "Invalid menu item in easymenu"

Re: easy-menu subtlety

[Stefan Monnier]

>> > The last 3 lines of this code sequence in lisp/progmodes/verilog-mode.el:
>> >
>> >     ("Move"
>> >      ,(if (featurep 'xemacs)
>> >           (progn 
>> >             ["Beginning of function"            verilog-beg-of-defun t]
>> >             ["End of function"                  verilog-end-of-defun t]
>> >             ["Mark function"                    verilog-mark-defun t])
>> >         ["Beginning of function"                beginning-of-defun t]
>> >         ["End of function"                      end-of-defun t]
>> >         ["Mark function"                        mark-defun t])
>> 
>> That looks completely bogus to me.  The result of the evaluation of the
>> form is a single vector, with the other two just thrown away.  I think
>> the intention was to write this:
>> 
>> ("Move"
>> ,@(if (featurep 'xemacs)
>> '(["Beginning of function"		verilog-beg-of-defun t]
>> ["End of function"			verilog-end-of-defun t]
>> ["Mark function"			verilog-mark-defun t])
>> '(["Beginning of function"		beginning-of-defun t]
>> ["End of function"			end-of-defun t]
>> ["Mark function"			mark-defun t]))

> Thanks, but it doesn't work with emacs-21: "Invalid menu item in easymenu"

I don't see any good reason for it not to work.  Most likely it's some
silly detail somewhere.  This said, I'd recommend you just remove the
test and use the XEmacs side of the code, and make sure that
verilog-beg-of-defun is always defined (and make it an alias to
beginning-of-defun under Emacs).


        Stefan

Re: easy-menu subtlety

[Dan Nicolaescu]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

  > >> > The last 3 lines of this code sequence in lisp/progmodes/verilog-mode.el:
  > >> >
  > >> >     ("Move"
  > >> >      ,(if (featurep 'xemacs)
  > >> >           (progn 
  > >> >             ["Beginning of function"            verilog-beg-of-defun t]
  > >> >             ["End of function"                  verilog-end-of-defun t]
  > >> >             ["Mark function"                    verilog-mark-defun t])
  > >> >         ["Beginning of function"                beginning-of-defun t]
  > >> >         ["End of function"                      end-of-defun t]
  > >> >         ["Mark function"                        mark-defun t])
  > >> 
  > >> That looks completely bogus to me.  The result of the evaluation of the
  > >> form is a single vector, with the other two just thrown away.  I think
  > >> the intention was to write this:
  > >> 
  > >> ("Move"
  > >> ,@(if (featurep 'xemacs)
  > >> '(["Beginning of function"		verilog-beg-of-defun t]
  > >> ["End of function"			verilog-end-of-defun t]
  > >> ["Mark function"			verilog-mark-defun t])
  > >> '(["Beginning of function"		beginning-of-defun t]
  > >> ["End of function"			end-of-defun t]
  > >> ["Mark function"			mark-defun t]))
  > 
  > > Thanks, but it doesn't work with emacs-21: "Invalid menu item in easymenu"
  > 
  > I don't see any good reason for it not to work.  Most likely it's some
  > silly detail somewhere.  This said, I'd recommend you just remove the
  > test and use the XEmacs side of the code, and make sure that
  > verilog-beg-of-defun is always defined (and make it an alias to
  > beginning-of-defun under Emacs).

The only problem with that is that C-M-a and C-M-e won't appear in the
"Beginning of function" and "End of function" menu entries.  They would
appear if the explicit C-M-a and C-M-e bindings for
verilog-beg-of-defun/verilog-end-of-defun are also enabled for emacs.
But that is ugly... 

Re: easy-menu subtlety

[Stefan Monnier]

> The only problem with that is that C-M-a and C-M-e won't appear in the
> "Beginning of function" and "End of function" menu entries.  They would
> appear if the explicit C-M-a and C-M-e bindings for
> verilog-beg-of-defun/verilog-end-of-defun are also enabled for emacs.
> But that is ugly... 

Of course, you'd change the keymap accordingly as well.


        Stefan