grep-mode-map & compilation-minor-mode-map

grep-mode-map & compilation-minor-mode-map

[Sam Steingold]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

1. grep.el uses (cons 'keymap compilation-minor-mode-map) instead of
more "abstract"
~  (let ((map (make-sparse-keymap)))
~    (set-keymap-parent map compilation-minor-mode-map)
is there a specific reason for that?

2. is it OK to add these to compilation-minor-mode-map?
~  (define-key map "g" 'recompile) ; revert
~  (define-key map "q" 'quit-window)
they appear to be rather standard for non-self-insert buffers and rather
useful as well.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFIIgWsPp1Qsf2qnMcRAmEEAJ96ptWzD3bK+v7HbK0m+hVAx5iP5ACeJab9
Mcljr4rhE7dlQn8I+e4XVtM=
=w4T2
-----END PGP SIGNATURE-----

Re: grep-mode-map & compilation-minor-mode-map

[Stefan Monnier]

> 1. grep.el uses (cons 'keymap compilation-minor-mode-map) instead of
> more "abstract"
> ~  (let ((map (make-sparse-keymap)))
> ~    (set-keymap-parent map compilation-minor-mode-map)
> is there a specific reason for that?

No.

> 2. is it OK to add these to compilation-minor-mode-map?
> ~  (define-key map "g" 'recompile) ; revert
> ~  (define-key map "q" 'quit-window)
> they appear to be rather standard for non-self-insert buffers and rather
> useful as well.

I'm not sure about these bindings.  Currently, other than RET, this
minor-mode map doesn't bind any of the normal editing keys.
Maybe it'd be better to add them to grep only for now,


        Stefan

Re: grep-mode-map & compilation-minor-mode-map

[Sam Steingold]

> * Stefan Monnier <zbaavre@veb.hzbagerny.pn> [2008-05-07 21:53:52 -0400]:
>
>> 2. is it OK to add these to compilation-minor-mode-map?
>> ~  (define-key map "g" 'recompile) ; revert
>> ~  (define-key map "q" 'quit-window)
>> they appear to be rather standard for non-self-insert buffers and rather
>> useful as well.
>
> I'm not sure about these bindings.  Currently, other than RET, this
> minor-mode map doesn't bind any of the normal editing keys.
> Maybe it'd be better to add them to grep only for now,

binding RET indicates all the buffers using this map
will be read-only, so I don't see why not add it here.
I you absolutely sure you do not want it?

-- 
Sam Steingold (http://sds.podval.org/) on Fedora release 8 (Werewolf)
http://ffii.org http://dhimmi.com http://truepeace.org
http://iris.org.il http://mideasttruth.com http://openvotingconsortium.org
Linux: Telling Microsoft where to go since 1991.