From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Sam Steingold <sds@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: grep-mode-map & compilation-minor-mode-map
Date: Wed, 07 May 2008 21:53:52 -0400 [thread overview]
Message-ID: <jwvk5i5zhwc.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <482205AC.1040708@gnu.org> (Sam Steingold's message of "Wed, 07 May 2008 15:40:28 -0400")
> 1. grep.el uses (cons 'keymap compilation-minor-mode-map) instead of
> more "abstract"
> ~ (let ((map (make-sparse-keymap)))
> ~ (set-keymap-parent map compilation-minor-mode-map)
> is there a specific reason for that?
No.
> 2. is it OK to add these to compilation-minor-mode-map?
> ~ (define-key map "g" 'recompile) ; revert
> ~ (define-key map "q" 'quit-window)
> they appear to be rather standard for non-self-insert buffers and rather
> useful as well.
I'm not sure about these bindings. Currently, other than RET, this
minor-mode map doesn't bind any of the normal editing keys.
Maybe it'd be better to add them to grep only for now,
Stefan
next prev parent reply other threads:[~2008-05-08 1:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-07 19:40 grep-mode-map & compilation-minor-mode-map Sam Steingold
2008-05-08 1:53 ` Stefan Monnier [this message]
2008-05-08 4:19 ` Sam Steingold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvk5i5zhwc.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=sds@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.