From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [patch] vc-find-root with invert Date: Mon, 21 Jul 2008 14:32:16 -0400 Message-ID: References: <486E5CE0.5090004@justinbogner.com> <486E668E.2050600@justinbogner.com> <20080705072126.GA936@tomas> <4884B8FC.9040301@justinbogner.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1216665165 5795 80.91.229.12 (21 Jul 2008 18:32:45 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 21 Jul 2008 18:32:45 +0000 (UTC) Cc: emacs-devel@gnu.org To: Justin Bogner Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jul 21 20:33:34 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KL0CH-00008l-QX for ged-emacs-devel@m.gmane.org; Mon, 21 Jul 2008 20:33:22 +0200 Original-Received: from localhost ([127.0.0.1]:43192 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KL0BO-0006aX-RE for ged-emacs-devel@m.gmane.org; Mon, 21 Jul 2008 14:32:26 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KL0BJ-0006YX-KU for emacs-devel@gnu.org; Mon, 21 Jul 2008 14:32:21 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KL0BI-0006X4-4y for emacs-devel@gnu.org; Mon, 21 Jul 2008 14:32:21 -0400 Original-Received: from [199.232.76.173] (port=54139 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KL0BH-0006Wp-S3 for emacs-devel@gnu.org; Mon, 21 Jul 2008 14:32:19 -0400 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:45563) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KL0BH-0004KU-0m for emacs-devel@gnu.org; Mon, 21 Jul 2008 14:32:19 -0400 Original-Received: from alfajor.home (vpn-132-204-232-79.acd.umontreal.ca [132.204.232.79]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id m6LIWff2011744; Mon, 21 Jul 2008 14:32:41 -0400 Original-Received: by alfajor.home (Postfix, from userid 20848) id D51661C523; Mon, 21 Jul 2008 14:32:16 -0400 (EDT) In-Reply-To: <4884B8FC.9040301@justinbogner.com> (Justin Bogner's message of "Mon, 21 Jul 2008 10:27:40 -0600") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV3064=0 X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:101107 Archived-At: >> Reading the docstring, my guess would be: vc-find-root walks the dir >> tree up _until_ it finds WITNESS (as an evidence for the VC tree's root >> dir). Unless we have CVS or SVN or similar, where every subdir has >> WITNESS, so the root would be the last up-tree directory having WITNESS. That still doesn't tell me what it does. I mean I can read the code and understand what is the effect of calling the code like this, but I have no idea what effect it has for the user. AFAICT it's a misfeature. > This is exactly correct, though in the current trunk there is a bug > such that the function does not behave like this. The patch causes it > to work as documented. I think we should remove this misfeature rather than fix it. Stefan