From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Justin Bogner <mail@justinbogner.com>
Cc: emacs-devel@gnu.org
Subject: Re: [patch] vc-find-root with invert
Date: Mon, 21 Jul 2008 14:32:16 -0400 [thread overview]
Message-ID: <jwvk5ff84yi.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <4884B8FC.9040301@justinbogner.com> (Justin Bogner's message of "Mon, 21 Jul 2008 10:27:40 -0600")
>> Reading the docstring, my guess would be: vc-find-root walks the dir
>> tree up _until_ it finds WITNESS (as an evidence for the VC tree's root
>> dir). Unless we have CVS or SVN or similar, where every subdir has
>> WITNESS, so the root would be the last up-tree directory having WITNESS.
That still doesn't tell me what it does. I mean I can read the code and
understand what is the effect of calling the code like this, but I have
no idea what effect it has for the user. AFAICT it's a misfeature.
> This is exactly correct, though in the current trunk there is a bug
> such that the function does not behave like this. The patch causes it
> to work as documented.
I think we should remove this misfeature rather than fix it.
Stefan
next prev parent reply other threads:[~2008-07-21 18:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-04 17:24 [patch] vc-find-root with invert Justin Bogner
2008-07-04 18:02 ` Stefan Monnier
2008-07-04 18:06 ` Justin Bogner
2008-07-04 19:52 ` Stefan Monnier
2008-07-05 7:21 ` tomas
2008-07-21 16:27 ` Justin Bogner
2008-07-21 18:32 ` Stefan Monnier [this message]
2008-07-21 21:33 ` Justin Bogner
2008-07-21 22:00 ` David Kastrup
2008-07-21 22:23 ` Justin Bogner
2008-07-21 23:02 ` David Kastrup
2008-07-23 4:35 ` Justin Bogner
2008-07-23 19:35 ` Stefan Monnier
2008-07-22 2:56 ` Stefan Monnier
-- strict thread matches above, loose matches on Subject: below --
2008-07-04 17:47 Justin Bogner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvk5ff84yi.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=mail@justinbogner.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.