Calc window handling

Calc window handling

[Chong Yidong]

Hi Jay,

Something broke in the calc window handling recently, at least in my CVS
build.  I don't know whether calc, or Emacs's window management is at
fault.

 emacs -Q
 M-x calc
 q

   => The selected buffer is the Calc buffer, as the only window on the
      frame.  The Calc buffer is supposed to be buried!

Did you change anything in Calc that might have caused this?

Re: Calc window handling

[martin rudalics]

 > Something broke in the calc window handling recently, at least in my CVS
 > build.  I don't know whether calc, or Emacs's window management is at
 > fault.
 >
 >  emacs -Q
 >  M-x calc
 >  q
 >
 >    => The selected buffer is the Calc buffer, as the only window on the
 >       frame.  The Calc buffer is supposed to be buried!
 >
 > Did you change anything in Calc that might have caused this?

Jay didn't do anything.  I recently changed `delete-windows-on' to make
a nil argument default to the current buffer and it seems `calc-quit' is
calling `delete-windows-on' a couple of times with argument nil _not_
meaning the current buffer.  I felt quite sure about my change because
according to the documentation nil was not considered a valid argument
till now for `delete-windows-on' and most other functions in this area
have nil stand for the current buffer.

martin

Re: Calc window handling

[Chong Yidong]

martin rudalics <rudalics@gmx.at> writes:

>>  emacs -Q
>>  M-x calc
>>  q
>>
>>    => The selected buffer is the Calc buffer, as the only window on the
>>       frame.  The Calc buffer is supposed to be buried!
>
> I recently changed `delete-windows-on' to make a nil argument default
> to the current buffer and it seems `calc-quit' is calling
> `delete-windows-on' a couple of times with argument nil _not_ meaning
> the current buffer.  I felt quite sure about my change because
> according to the documentation nil was not considered a valid argument
> till now for `delete-windows-on' and most other functions in this area
> have nil stand for the current buffer.

I'm not sure what you're referring to.  As far as I can tell, calc-quit
doesn't call delete-windows-on with nil arguments: it uses the Calc
buffers as the argument.

Re: Calc window handling

[Jay Belanger]

Chong Yidong <cyd@stupidchicken.com> writes:
...
> I'm not sure what you're referring to.  As far as I can tell, calc-quit
> doesn't call delete-windows-on with nil arguments: it uses the Calc
> buffers as the argument.

But one of those arguments is kbuf, which is equal to 
(get-buffer "*Calc Keypad*"). If no such buffer exists, then
(delete-windows-on kbuf) will bury the current buffer and bring the Calc
buffer back to the top.  I will change calc-quit so that it checks to
see if a buffer exists before calling delete-window-on on it.

Jay

Re: Calc window handling

[Stefan Monnier]

> Something broke in the calc window handling recently, at least in my CVS
> build.  I don't know whether calc, or Emacs's window management is at
> fault.

>  emacs -Q
>  M-x calc
>  q

>    => The selected buffer is the Calc buffer, as the only window on the
>       frame.  The Calc buffer is supposed to be buried!

> Did you change anything in Calc that might have caused this?

Sounds like the recent change to quit-window.


        Stefan