From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#753: [Fwd: sh-script.el: indentation of ( )] Date: Fri, 09 Jan 2009 12:24:02 -0500 Message-ID: References: <48AC8E68.8080503@t-online.de> <7f8wpl430a.fsf@fencepost.gnu.org> Reply-To: Stefan Monnier , 753@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1231523118 12396 80.91.229.12 (9 Jan 2009 17:45:18 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 9 Jan 2009 17:45:18 +0000 (UTC) Cc: 753@emacsbugs.donarmstrong.com To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jan 09 18:46:29 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LLLQz-0003Rw-4j for geb-bug-gnu-emacs@m.gmane.org; Fri, 09 Jan 2009 18:46:13 +0100 Original-Received: from localhost ([127.0.0.1]:49504 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LLLPj-0008ND-3s for geb-bug-gnu-emacs@m.gmane.org; Fri, 09 Jan 2009 12:44:55 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LLLOK-0007Ps-Li for bug-gnu-emacs@gnu.org; Fri, 09 Jan 2009 12:43:28 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LLLOJ-0007OY-Ki for bug-gnu-emacs@gnu.org; Fri, 09 Jan 2009 12:43:28 -0500 Original-Received: from [199.232.76.173] (port=47345 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LLLOJ-0007OI-DK for bug-gnu-emacs@gnu.org; Fri, 09 Jan 2009 12:43:27 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:38452) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LLLOI-0005JY-S2 for bug-gnu-emacs@gnu.org; Fri, 09 Jan 2009 12:43:27 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n09HhOR5015394; Fri, 9 Jan 2009 09:43:25 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n09HU3k0011817; Fri, 9 Jan 2009 09:30:03 -0800 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Stefan Monnier Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Fri, 09 Jan 2009 17:30:02 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 753 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 753-submit@emacsbugs.donarmstrong.com id=B753.123152185110552 (code B ref 753); Fri, 09 Jan 2009 17:30:02 +0000 Original-Received: (at 753) by emacsbugs.donarmstrong.com; 9 Jan 2009 17:24:11 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from chene.dit.umontreal.ca (chene.dit.umontreal.ca [132.204.246.20]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n09HO4kk010546 for <753@emacsbugs.donarmstrong.com>; Fri, 9 Jan 2009 09:24:05 -0800 Original-Received: from alfajor.home (vpn-132-204-232-74.acd.umontreal.ca [132.204.232.74]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id n09HO2vJ028858; Fri, 9 Jan 2009 12:24:02 -0500 Original-Received: by alfajor.home (Postfix, from userid 20848) id 78B8F1C266; Fri, 9 Jan 2009 12:24:02 -0500 (EST) In-Reply-To: (Glenn Morris's message of "Fri, 09 Jan 2009 00:02:28 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV3185=0 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Fri, 09 Jan 2009 12:43:28 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:23945 Archived-At: >> It doesn't matter. "done)" is not an entity in `sh', so we should not >> treat it as one. > Yes, but it is a useful shortcut to treat it as one IMO, since it > gets the indentation "mostly right" for little effort. It still gets it wrong for "done )". And it introduces bugs elsewhere. I'm pretty sure it was not done on purpose: it's basically a bug that accidentally does the right thing in some corner cases. > I'm afraid I don't know how to fix it (indentation) properly, so I > reopened this bug. We know how to fix the OP's bug without re-introducing the bug that my misguided patch tried to fix. So we should do that and close this bug. Then we can open another bug about the "done )" case pattern since it's a different bug. Stefan