From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#4176: Acknowledgement (23.1; partial completions) Date: Mon, 17 Aug 2009 15:57:21 -0400 Message-ID: References: <19081.26994.931953.186612@winooski.ccs.neu.edu> <19081.28312.991657.218640@winooski.ccs.neu.edu> Reply-To: Stefan Monnier , 4176@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1250539644 11454 80.91.229.12 (17 Aug 2009 20:07:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 17 Aug 2009 20:07:24 +0000 (UTC) Cc: 4176@emacsbugs.donarmstrong.com To: Eli Barzilay Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Aug 17 22:07:17 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Md8U7-0001HF-Sz for geb-bug-gnu-emacs@m.gmane.org; Mon, 17 Aug 2009 22:07:16 +0200 Original-Received: from localhost ([127.0.0.1]:39894 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Md8U7-0008UB-C4 for geb-bug-gnu-emacs@m.gmane.org; Mon, 17 Aug 2009 16:07:15 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Md8Tr-0008CF-Dj for bug-gnu-emacs@gnu.org; Mon, 17 Aug 2009 16:06:59 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Md8Tl-00088g-IW for bug-gnu-emacs@gnu.org; Mon, 17 Aug 2009 16:06:58 -0400 Original-Received: from [199.232.76.173] (port=42696 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Md8Tl-00088d-Ef for bug-gnu-emacs@gnu.org; Mon, 17 Aug 2009 16:06:53 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:40347) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Md8Tk-0005qW-Eo for bug-gnu-emacs@gnu.org; Mon, 17 Aug 2009 16:06:52 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n7HK6oop023559; Mon, 17 Aug 2009 13:06:50 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id n7HK55Qm022858; Mon, 17 Aug 2009 13:05:05 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Stefan Monnier Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Mon, 17 Aug 2009 20:05:04 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 4176 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 4176-submit@emacsbugs.donarmstrong.com id=B4176.125053904921247 (code B ref 4176); Mon, 17 Aug 2009 20:05:04 +0000 Original-Received: (at 4176) by emacsbugs.donarmstrong.com; 17 Aug 2009 19:57:29 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from ironport2-out.teksavvy.com (ironport2-out.pppoe.ca [206.248.154.182]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n7HJvRaU021244 for <4176@emacsbugs.donarmstrong.com>; Mon, 17 Aug 2009 12:57:28 -0700 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AhAFALBSiUpFpZNo/2dsb2JhbACBUtQQhBkFgU2FfA X-IronPort-AV: E=Sophos;i="4.43,398,1246852800"; d="scan'208";a="43680033" Original-Received: from 69-165-147-104.dsl.teksavvy.com (HELO pastel.home) ([69.165.147.104]) by ironport2-out.teksavvy.com with ESMTP; 17 Aug 2009 15:56:49 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 26F5C82F0; Mon, 17 Aug 2009 15:57:21 -0400 (EDT) In-Reply-To: <19081.28312.991657.218640@winooski.ccs.neu.edu> (Eli Barzilay's message of "Mon, 17 Aug 2009 10:52:08 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Resent-Date: Mon, 17 Aug 2009 16:06:58 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:30317 Archived-At: > After a quick look, I tried to redefine `minibuffer-complete' and just > comment out the second (goto-char (field-end)). This seems to work > wrt wrongly moving the cursor to the end which seems to resolve both [...] > 1. Since this code was put there explicitly, there must be some issue > I don't see in removing it. I don't have time to dig into this right now, but the cursor placement is fairly tricky indeed, and there are often different valid choices depending on your particular preferences. The rule I tried to follow (in the partia-completion code) is that the cursor should be placed to the rightmost position that still offers ways to persue completion. In your `select-window' example, it seems that the behavior doesn't follow this rule, so it might indeed be a plain bug. > 2. Even after the quick code browse I have no idea what wonderful > features I'm losing by removing `basic' and `emacs22' from > `completion-styles'. I would be happy if someone can enlighten me. You lose the fact that the default Emacs-23 completion is a compromise between the non-partial-completion and the partial-completion behavior. If you used partial-completion and liked it, you probably want to do (setq completion-styles '(partial-completion)) like you did. But remember that enabling partial-completion by default in Emacs-23 didn't get accepted without a fight. Stefan