all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Eli Barzilay <eli@barzilay.org>
Cc: 4176@emacsbugs.donarmstrong.com
Subject: bug#4176: Acknowledgement (23.1; partial completions)
Date: Mon, 17 Aug 2009 15:57:21 -0400	[thread overview]
Message-ID: <jwvk512b4ml.fsf-monnier+emacsbugreports@gnu.org> (raw)
In-Reply-To: <19081.28312.991657.218640@winooski.ccs.neu.edu> (Eli Barzilay's message of "Mon, 17 Aug 2009 10:52:08 -0400")

> After a quick look, I tried to redefine `minibuffer-complete' and just
> comment out the second (goto-char (field-end)).  This seems to work
> wrt wrongly moving the cursor to the end which seems to resolve both
[...]
> 1. Since this code was put there explicitly, there must be some issue
>    I don't see in removing it.

I don't have time to dig into this right now, but the cursor placement
is fairly tricky indeed, and there are often different valid choices
depending on your particular preferences.

The rule I tried to follow (in the partia-completion code) is that the
cursor should be placed to the rightmost position that still offers ways
to persue completion.  In your `select-window' example, it seems that
the behavior doesn't follow this rule, so it might indeed be
a plain bug.

> 2. Even after the quick code browse I have no idea what wonderful
>    features I'm losing by removing `basic' and `emacs22' from
>    `completion-styles'.  I would be happy if someone can enlighten me.

You lose the fact that the default Emacs-23 completion is a compromise
between the non-partial-completion and the partial-completion behavior.
If you used partial-completion and liked it, you probably want to do
(setq completion-styles '(partial-completion)) like you did.
But remember that enabling partial-completion by default in Emacs-23
didn't get accepted without a fight.


        Stefan





  reply	other threads:[~2009-08-17 19:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <jwv1vn9uev7.fsf-monnier+emacsbugreports@gnu.org>
2009-08-17 14:30 ` bug#4176: 23.1; partial completions Eli Barzilay
     [not found]   ` <handler.4176.B.125051942125598.ack@emacsbugs.donarmstrong.com>
2009-08-17 14:52     ` bug#4176: Acknowledgement (23.1; partial completions) Eli Barzilay
2009-08-17 19:57       ` Stefan Monnier [this message]
2009-08-20 20:30   ` bug#4176: marked as done " Emacs bug Tracking System

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvk512b4ml.fsf-monnier+emacsbugreports@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=4176@emacsbugs.donarmstrong.com \
    --cc=eli@barzilay.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.