all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* bookmark.el bug report
@ 2009-12-28  6:19 Sun Yijiang
  2009-12-28  6:48 ` Karl Fogel
  2010-01-02  5:05 ` Karl Fogel
  0 siblings, 2 replies; 21+ messages in thread
From: Sun Yijiang @ 2009-12-28  6:19 UTC (permalink / raw)
  To: emacs-devel

`bookmark-bmenu-execute-deletions' is broken for quite some time.  I
think I've found the problem.  When it calls
`bookmark-bmenu-bookmark', the callee gets text property at
`(line-begging-position)', which is incorrect in this context.  Below
is the patched code of  `bookmark-bmenu-bookmark' that works for me:

(defun bookmark-bmenu-bookmark ()
  "Return the bookmark for this line in an interactive bookmark list buffer."
  (when (bookmark-bmenu-check-position)
    (let ((pos (line-beginning-position)))
      (when (looking-back "^[^ ]")
        (setq pos (+ 1 pos)))
      (get-text-property pos 'bookmark-name-prop))))


Sincerely,
Steve




^ permalink raw reply	[flat|nested] 21+ messages in thread

end of thread, other threads:[~2010-01-02 19:17 UTC | newest]

Thread overview: 21+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-28  6:19 bookmark.el bug report Sun Yijiang
2009-12-28  6:48 ` Karl Fogel
2009-12-28  7:41   ` Thierry Volpiatto
2009-12-28 15:58     ` Drew Adams
2009-12-28 21:12       ` Karl Fogel
2009-12-29 18:22         ` Stefan Monnier
2009-12-30 13:37           ` Thierry Volpiatto
2009-12-30 15:28             ` Stefan Monnier
2009-12-30 15:57               ` Drew Adams
2009-12-30 16:26                 ` Drew Adams
2009-12-30 17:43               ` Thierry Volpiatto
2009-12-30 18:32                 ` Stefan Monnier
2010-01-02  5:05 ` Karl Fogel
2010-01-02  5:15   ` Karl Fogel
2010-01-02  7:03     ` Thierry Volpiatto
2010-01-02  7:26       ` Karl Fogel
2010-01-02  8:15         ` Thierry Volpiatto
2010-01-02 19:17           ` Karl Fogel
2010-01-02  7:51   ` Drew Adams
2010-01-02  8:16     ` Karl Fogel
2010-01-02  8:42       ` Drew Adams

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.