From: Stefan Monnier <monnier@iro.umontreal.ca>
To: joakim@verona.se
Cc: Emacs development discussions <emacs-devel@gnu.org>
Subject: Re: imagemmagick patch 5
Date: Wed, 03 Mar 2010 21:41:03 -0500 [thread overview]
Message-ID: <jwvk4ts6chj.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <m3eik1dfau.fsf@verona.se> (joakim@verona.se's message of "Wed, 03 Mar 2010 08:39:53 +0100")
> The Imagemagick patch allows Emacs to use the Imagemagick libraries to
> load images. This support can be used in parallell with the existing
> image loading support. There is support for asking your imagemagick
> installation which image types it supports, and registering them in
> Emacs selectively.
Thanks. Looks pretty good. Feel free to install it in the `pending'
branch, but please see the comments below first, and don't forget to add
a good NEWS entry when you install this change.
> +HAVE_IMAGEMAGICK=no
> +if test "${HAVE_X11}" = "yes" ; then
Do I understand it right that this X11-only restriction could be lifted
at some point in the future?
> diff --git a/src/dbusbind.c b/src/dbusbind.c
> index 7c0be49..7a47730 100644
> --- a/src/dbusbind.c
> +++ b/src/dbusbind.c
> @@ -773,6 +773,7 @@ xd_add_watch (watch, data)
> if (fd == -1)
> return FALSE;
>
> +
> /* Add the file descriptor to input_wait_mask. */
> add_keyboard_wait_descriptor (fd);
> }
Please drop this gratuitous change.
> +/***********************************************************************
> + imagemagick
> + ***********************************************************************/
> +#if defined (HAVE_IMAGEMAGICK)
> +Lisp_Object Vimagemagick_render_type;
> +/* Function prototypes. */
> +
> +static int imagemagick_image_p P_ ((Lisp_Object object));
> +static int imagemagick_load P_ ((struct frame *f, struct image *img));
> +
> +static int imagemagick_load_image P_ ((struct frame *, struct image *,
> + unsigned char *, unsigned int, unsigned char *));
Please don't use the P_ macro in new code: just use prototypes.
> +//#include "/home/joakim/current/unison/data/ImageMagick-6.5.4-7/magick/xwindow-private.h"
This should be removed as well.
> + //try if magicexportimage is any faster than pixelpushing
[...]
> + //oddly, the below code doesnt seem to work:
We currently only use /*...*/ comments, so I'd rather we don't introduce
// comments for now.
Stefan
next prev parent reply other threads:[~2010-03-04 2:41 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-03 7:39 imagemmagick patch 5 joakim
2010-03-03 19:34 ` Juri Linkov
2010-03-03 20:03 ` joakim
2010-03-06 17:59 ` Juri Linkov
2010-03-06 20:16 ` Stefan Monnier
2010-03-06 21:05 ` Juri Linkov
2010-03-07 14:37 ` Stefan Monnier
2010-03-07 19:08 ` Juri Linkov
2010-03-07 21:23 ` Stefan Monnier
2010-03-13 17:44 ` Kim F. Storm
2010-03-30 16:12 ` Image metadata (was: imagemmagick patch 5) Juri Linkov
2010-03-30 20:36 ` Image metadata Stefan Monnier
2010-03-30 22:38 ` Juri Linkov
2010-03-31 1:22 ` Stefan Monnier
2010-04-02 21:51 ` joakim
2010-04-02 22:38 ` Juri Linkov
2010-03-04 2:41 ` Stefan Monnier [this message]
2010-03-05 22:06 ` imagemmagick patch 5 joakim
2010-03-05 22:30 ` Stefan Monnier
2010-03-05 23:56 ` Jan Djärv
2010-03-06 6:02 ` Stephen J. Turnbull
2010-04-15 9:34 ` joakim
2010-04-15 10:55 ` joakim
2010-04-16 20:45 ` Juri Linkov
2010-04-17 6:09 ` joakim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvk4ts6chj.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=joakim@verona.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.