From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Julien Danjou <julien@danjou.info>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH 2/2] avoid: ignore mouse when it is hidden
Date: Mon, 18 Oct 2010 10:42:28 -0400 [thread overview]
Message-ID: <jwvk4lfwoll.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <1287067949-23750-3-git-send-email-julien@danjou.info> (Julien Danjou's message of "Thu, 14 Oct 2010 16:52:29 +0200")
> (defun mouse-avoidance-ignore-p ()
> (let ((mp (mouse-position)))
> - (or executing-kbd-macro ; don't check inside macro
> + (or (not (frame-pointer-visible-p)) ; The pointer is hidden
> + executing-kbd-macro ; don't check inside macro
> (null (cadr mp)) ; don't move unless in an Emacs frame
> (not (eq (car mp) (selected-frame)))
> ;; Don't do anything if last event was a mouse event.
Just wondering here: seeing how you've gone through the trouble to write
a patch for the C code, there must be a good reason, but why check (not
(frame-pointer-visible-p)) rather than make-pointer-invisible?
Stefan
next prev parent reply other threads:[~2010-10-18 14:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-14 14:52 Export pointer visibility Julien Danjou
2010-10-14 14:52 ` [PATCH 1/2] Add frame-pointer-visible-p Julien Danjou
2010-10-17 19:11 ` Stefan Monnier
2010-10-18 9:31 ` Julien Danjou
2010-10-18 9:53 ` Andreas Schwab
2010-10-18 10:05 ` Lennart Borgman
2010-10-18 10:31 ` Eli Zaretskii
2010-10-18 10:54 ` Eli Zaretskii
2010-10-18 12:12 ` Julien Danjou
2010-10-18 13:05 ` Eli Zaretskii
2010-10-18 21:08 ` Stefan Monnier
2010-10-14 14:52 ` [PATCH 2/2] avoid: ignore mouse when it is hidden Julien Danjou
2010-10-18 14:42 ` Stefan Monnier [this message]
2010-10-18 14:47 ` Julien Danjou
2010-10-18 21:10 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvk4lfwoll.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=julien@danjou.info \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.