From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#7231: 23.3; Don't rebuild buffer list in iswitchb-visit-buffer Date: Wed, 20 Oct 2010 12:13:08 -0400 Message-ID: References: <87r5foy90j.fsf@telefonica.net> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1287595240 11262 80.91.229.12 (20 Oct 2010 17:20:40 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 20 Oct 2010 17:20:40 +0000 (UTC) Cc: =?UTF-8?Q?=C3=93scar?= Fuentes , 7231@debbugs.gnu.org To: Leo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Oct 20 19:20:37 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1P8cL6-0003w3-SA for geb-bug-gnu-emacs@m.gmane.org; Wed, 20 Oct 2010 19:20:37 +0200 Original-Received: from localhost ([127.0.0.1]:41346 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P8cCZ-0002lF-6g for geb-bug-gnu-emacs@m.gmane.org; Wed, 20 Oct 2010 13:11:47 -0400 Original-Received: from [140.186.70.92] (port=49352 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P8cAl-0001yX-QZ for bug-gnu-emacs@gnu.org; Wed, 20 Oct 2010 13:09:59 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P8cAl-0003TL-4p for bug-gnu-emacs@gnu.org; Wed, 20 Oct 2010 13:09:56 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:49451) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P8bkL-0007ZA-SZ for bug-gnu-emacs@gnu.org; Wed, 20 Oct 2010 12:42:37 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1P8bEp-0005I6-BD; Wed, 20 Oct 2010 12:10:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 20 Oct 2010 16:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7231 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 7231-submit@debbugs.gnu.org id=B7231.128759096320325 (code B ref 7231); Wed, 20 Oct 2010 16:10:02 +0000 Original-Received: (at 7231) by debbugs.gnu.org; 20 Oct 2010 16:09:23 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P8bEA-0005Hm-9w for submit@debbugs.gnu.org; Wed, 20 Oct 2010 12:09:22 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181] helo=ironport2-out.pppoe.ca) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P8bE9-0005Hh-5H for 7231@debbugs.gnu.org; Wed, 20 Oct 2010 12:09:21 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: An8KAK+xvkxMCpO7/2dsb2JhbACgUnpyv1mFSgSSGw X-IronPort-AV: E=Sophos;i="4.57,356,1283745600"; d="scan'208";a="80225644" Original-Received: from 76-10-147-187.dsl.teksavvy.com (HELO ceviche.home) ([76.10.147.187]) by ironport2-out.pppoe.ca with ESMTP/TLS/ADH-AES256-SHA; 20 Oct 2010 12:13:09 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 0873B66112; Wed, 20 Oct 2010 12:13:09 -0400 (EDT) In-Reply-To: (Leo's message of "Wed, 20 Oct 2010 11:00:00 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Wed, 20 Oct 2010 12:10:03 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:41014 Archived-At: >> I was about to install that change when I realized that this is >> fundamentally not the right approach: since some of the buffers may have >> changed name, the new list of matching buffers may be different (some >> buffers that didn't match before may match now and vice-versa). >> >> So iswitchb-make-buflist is more correct. To deal with the problem of >> ordering, we'll need to combine the two: call iswitchb-make-buflist to >> get the new list of matches, and then use bufobjs to sort the new >> iswitchb-buflist. > My understanding seems to be: > iswitchb-buflist already contains all buffers needed although its order > can be modified by iswitchb-next/prev-match. That modified ordering info > is lost after iswitchb-make-buflist. There may be new matches appearing > due to buffer name changes but this is taken care of automatically by > iswitchb-exhibit. I see, so iswitchb-buflist contains all buffers, not just the ones that match the current input? In that case, my concern is indeed a non-issue and your patch looks fine. Please install it. Stefan