From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Leo <sdl.web@gmail.com>
Cc: Drew Adams <drew.adams@oracle.com>, emacs-devel@gnu.org
Subject: Re: Any objection to adding completing-read-function?
Date: Wed, 22 Jun 2011 17:19:13 -0400 [thread overview]
Message-ID: <jwvk4cdbq19.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <m1tybizel1.fsf@th041141.ip.tsinghua.edu.cn> (Leo's message of "Wed, 22 Jun 2011 12:15:38 +0800")
>> The C code checks (memq minibuffer-completing-file-name '(nil
>> lambda)) instead. Are you sure your code is correct, and if so why?
> The value 'lambda is not documented anywhere. What's its meaning?
It's an internal hack and should mostly be invisible to the rest of the
Lisp code. It's explained in a comment in minibuf.c (search for
Qlambda).
Passing an initialization-function to read_minibuf (e.g. via the
initial-input arg) would make it possible to get rid of this hack, BTW.
BTW, your patch looks OK now, so if your tests indicate that it works
correctly, feel free to install it.
Stefan
next prev parent reply other threads:[~2011-06-22 21:19 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-28 8:03 Any objection to adding completing-read-function? Leo
2010-12-28 14:34 ` Stefan Monnier
2010-12-28 16:17 ` Drew Adams
2010-12-28 19:39 ` Stefan Monnier
2010-12-28 19:45 ` Drew Adams
2010-12-28 22:03 ` Stefan Monnier
2010-12-28 23:27 ` Leo
2010-12-29 2:51 ` Stefan Monnier
2010-12-29 8:16 ` Leo
2010-12-29 15:39 ` Stefan Monnier
2010-12-29 16:12 ` Leo
2011-03-20 13:07 ` Leo
2011-03-21 14:22 ` Stefan Monnier
2011-03-21 15:01 ` Leo
2010-12-28 19:02 ` Leo
2010-12-28 19:45 ` Stefan Monnier
2011-05-31 15:27 ` Drew Adams
2011-05-31 15:51 ` Stefan Monnier
2011-06-01 19:03 ` Leo
2011-06-09 11:53 ` Leo
2011-06-09 15:16 ` Stefan Monnier
2011-06-21 9:11 ` Leo
2011-06-22 1:50 ` Stefan Monnier
2011-06-22 4:15 ` Leo
2011-06-22 21:19 ` Stefan Monnier [this message]
2011-06-23 3:42 ` Leo
2010-12-28 16:17 ` Drew Adams
2010-12-28 19:07 ` Leo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvk4cdbq19.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=drew.adams@oracle.com \
--cc=emacs-devel@gnu.org \
--cc=sdl.web@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.