From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#10956: make-mode.el - improve makefile-warn-suspicious-lines Date: Wed, 21 Mar 2012 13:54:40 -0400 Message-ID: References: <62ehq5qt.fsf@test20.cante.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1332352532 28081 80.91.229.3 (21 Mar 2012 17:55:32 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 21 Mar 2012 17:55:32 +0000 (UTC) Cc: 10956@debbugs.gnu.org To: Jari Aalto Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Mar 21 18:55:31 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SAPkw-00080U-FH for geb-bug-gnu-emacs@m.gmane.org; Wed, 21 Mar 2012 18:55:30 +0100 Original-Received: from localhost ([::1]:36878 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SAPkv-0002XJ-UJ for geb-bug-gnu-emacs@m.gmane.org; Wed, 21 Mar 2012 13:55:29 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:56798) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SAPko-0002K3-0q for bug-gnu-emacs@gnu.org; Wed, 21 Mar 2012 13:55:28 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SAPkm-0005I3-AW for bug-gnu-emacs@gnu.org; Wed, 21 Mar 2012 13:55:21 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:53178) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SAPkm-0005Hw-7u for bug-gnu-emacs@gnu.org; Wed, 21 Mar 2012 13:55:20 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SAQEU-0006Mk-FD for bug-gnu-emacs@gnu.org; Wed, 21 Mar 2012 14:26:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 21 Mar 2012 18:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10956 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 10956-submit@debbugs.gnu.org id=B10956.133235432624403 (code B ref 10956); Wed, 21 Mar 2012 18:26:02 +0000 Original-Received: (at 10956) by debbugs.gnu.org; 21 Mar 2012 18:25:26 +0000 Original-Received: from localhost ([127.0.0.1]:59998 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SAQDu-0006LX-6P for submit@debbugs.gnu.org; Wed, 21 Mar 2012 14:25:26 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:53116) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SAQDr-0006LQ-UL for 10956@debbugs.gnu.org; Wed, 21 Mar 2012 14:25:24 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AicFAKU/KE9FxKFU/2dsb2JhbACBX5x7eYhwnhmDHIJ9BJsZhAk X-IronPort-AV: E=Sophos;i="4.73,1,1325480400"; d="scan'208";a="169219095" Original-Received: from 69-196-161-84.dsl.teksavvy.com (HELO pastel.home) ([69.196.161.84]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 21 Mar 2012 13:54:40 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 1292F58C3D; Wed, 21 Mar 2012 13:54:40 -0400 (EDT) In-Reply-To: <62ehq5qt.fsf@test20.cante.net> (Jari Aalto's message of "Tue, 06 Mar 2012 07:22:02 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.94 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:57932 Archived-At: > Here is a small patch to check any extra whitespace at the beginning of > line. The patch is against Emacs Vcs-Git ba7322c dated 2012-02-29. I must be missing something. All it does is change a "\t+$" to "[ \t]+$", so it's not really "at the beginning of line" (tho there's also a "^" in the regexp, so it really only applies to whitespace-only lines). I don't think we want to consider lines made up of spaces as suspicious. Stefan