From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#11604: USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup. Date: Mon, 04 Jun 2012 09:12:23 -0400 Message-ID: References: <4FC9522B.7050302@cs.ucla.edu> <83k3zqcgqg.fsf@gnu.org> <4FCB091F.4050602@cs.ucla.edu> <83y5o4bh6x.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1338815602 18137 80.91.229.3 (4 Jun 2012 13:13:22 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 4 Jun 2012 13:13:22 +0000 (UTC) Cc: 11604@debbugs.gnu.org, Paul Eggert To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jun 04 15:13:21 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SbX5z-0007mJ-HZ for geb-bug-gnu-emacs@m.gmane.org; Mon, 04 Jun 2012 15:13:19 +0200 Original-Received: from localhost ([::1]:46630 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SbX5z-00089Y-81 for geb-bug-gnu-emacs@m.gmane.org; Mon, 04 Jun 2012 09:13:19 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:38900) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SbX5s-00083D-BE for bug-gnu-emacs@gnu.org; Mon, 04 Jun 2012 09:13:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SbX5m-0001jU-20 for bug-gnu-emacs@gnu.org; Mon, 04 Jun 2012 09:13:11 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:47346) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SbX5l-0001jL-V7 for bug-gnu-emacs@gnu.org; Mon, 04 Jun 2012 09:13:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SbX7e-0003OG-5Q for bug-gnu-emacs@gnu.org; Mon, 04 Jun 2012 09:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Jun 2012 13:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11604 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 11604-submit@debbugs.gnu.org id=B11604.133881568712998 (code B ref 11604); Mon, 04 Jun 2012 13:15:02 +0000 Original-Received: (at 11604) by debbugs.gnu.org; 4 Jun 2012 13:14:47 +0000 Original-Received: from localhost ([127.0.0.1]:56892 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SbX7O-0003Nb-Vu for submit@debbugs.gnu.org; Mon, 04 Jun 2012 09:14:47 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:9655) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SbX74-0003N5-QE for 11604@debbugs.gnu.org; Mon, 04 Jun 2012 09:14:45 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Aj4FAG6Zu09sr+UI/2dsb2JhbABEsWCCMYEIghUBAQQBViMQCzQSFBgNJIgcBboJkEQDnjmEeoFYgwU X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="188569833" Original-Received: from 108-175-229-8.dsl.teksavvy.com (HELO ceviche.home) ([108.175.229.8]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 04 Jun 2012 09:12:24 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id C6D4F660E0; Mon, 4 Jun 2012 09:12:23 -0400 (EDT) In-Reply-To: <83y5o4bh6x.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 03 Jun 2012 17:31:18 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:60696 Archived-At: >> Because the union type is for debugging, not for production. > I didn't know that. If that is so, it should be mentioned in the > comments somewhere. (I actually thought that Stefan wants to move to > that model for production at some point, but maybe I misunderstood.) I'm not sure what it is you misunderstood, but I don't intend to use this "union type for Lisp_Object" for production. I encourage people around here to use it, to catch errors a bit earlier (tho, since they're caught by the compiler, a single user such as myself is enough to get a pretty good code coverage), but it has too many downsides (performance is one, 29bit ints vs 30bit ints is another). I would be OK with replacing it with a "struct". Stefan