From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#12215: CSET is unnecessarily confusing Date: Wed, 22 Aug 2012 09:27:03 -0400 Message-ID: References: <502D8A95.7060609@cs.ucla.edu> <5034511B.7010409@cs.ucla.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1345642072 4548 80.91.229.3 (22 Aug 2012 13:27:52 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 22 Aug 2012 13:27:52 +0000 (UTC) Cc: Dmitry Antipov , 12215@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Aug 22 15:27:52 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1T4AyN-0004pR-Hy for geb-bug-gnu-emacs@m.gmane.org; Wed, 22 Aug 2012 15:27:51 +0200 Original-Received: from localhost ([::1]:46730 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T4AyL-0007nI-Nh for geb-bug-gnu-emacs@m.gmane.org; Wed, 22 Aug 2012 09:27:49 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:43431) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T4AyE-0007hG-9p for bug-gnu-emacs@gnu.org; Wed, 22 Aug 2012 09:27:47 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T4AyA-0001Er-Ao for bug-gnu-emacs@gnu.org; Wed, 22 Aug 2012 09:27:42 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:33364) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T4AyA-0001Em-7M for bug-gnu-emacs@gnu.org; Wed, 22 Aug 2012 09:27:38 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1T4AyY-0007Ui-Hi for bug-gnu-emacs@gnu.org; Wed, 22 Aug 2012 09:28:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 22 Aug 2012 13:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12215 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 12215-submit@debbugs.gnu.org id=B12215.134564205428773 (code B ref 12215); Wed, 22 Aug 2012 13:28:02 +0000 Original-Received: (at 12215) by debbugs.gnu.org; 22 Aug 2012 13:27:34 +0000 Original-Received: from localhost ([127.0.0.1]:42910 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T4Ay5-0007U1-BQ for submit@debbugs.gnu.org; Wed, 22 Aug 2012 09:27:34 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:63383) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T4Ay2-0007Ts-42 for 12215@debbugs.gnu.org; Wed, 22 Aug 2012 09:27:30 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EAG6Zu09MCpcJ/2dsb2JhbABEDrQDgQiCFQEBBAEnLyMFCws0EhQYDSSIHAW6CZBEA6MzgViCMFU X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="196426031" Original-Received: from 76-10-151-9.dsl.teksavvy.com (HELO pastel.home) ([76.10.151.9]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 22 Aug 2012 09:27:04 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id E62BA4EA3D; Wed, 22 Aug 2012 09:27:03 -0400 (EDT) In-Reply-To: <5034511B.7010409@cs.ucla.edu> (Paul Eggert's message of "Tue, 21 Aug 2012 20:25:15 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:63393 Archived-At: >> CSET (XCHAR_TABLE (char_table), ->parent, parent); > That does avoid the ambiguity but it's pretty weird. Less weird than CSET (XCHAR_TABLE (char_table), parent, parent), and avoids the duplication of code we have with set_char_table_foobar. > How about something like this instead? > cset (XCHAR_TABLE (char_table), cset_parent, parent); > where cset_parent is an offset into the structure, or > is a member of a simple enumeration, whichever seems > cleaner. This would be functional and relatively > straightforward. Yuck! - code duplication. - offset into a struct instead of a plain field access? - worse, an enum instead of a plain field access? A non-starter. Stefan