From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: Dmitry Antipov <dmantipov@yandex.ru>, 12215@debbugs.gnu.org
Subject: bug#12215: CSET is unnecessarily confusing
Date: Wed, 22 Aug 2012 09:27:03 -0400 [thread overview]
Message-ID: <jwvk3wrxdqp.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <5034511B.7010409@cs.ucla.edu> (Paul Eggert's message of "Tue, 21 Aug 2012 20:25:15 -0700")
>> CSET (XCHAR_TABLE (char_table), ->parent, parent);
> That does avoid the ambiguity but it's pretty weird.
Less weird than CSET (XCHAR_TABLE (char_table), parent, parent),
and avoids the duplication of code we have with set_char_table_foobar.
> How about something like this instead?
> cset (XCHAR_TABLE (char_table), cset_parent, parent);
> where cset_parent is an offset into the structure, or
> is a member of a simple enumeration, whichever seems
> cleaner. This would be functional and relatively
> straightforward.
Yuck!
- code duplication.
- offset into a struct instead of a plain field access?
- worse, an enum instead of a plain field access?
A non-starter.
Stefan
next prev parent reply other threads:[~2012-08-22 13:27 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-17 0:04 bug#12215: CSET is unnecessarily confusing Paul Eggert
2012-08-17 4:12 ` Dmitry Antipov
2012-08-21 16:55 ` Stefan Monnier
2012-08-22 3:25 ` Paul Eggert
2012-08-22 13:27 ` Stefan Monnier [this message]
2012-08-22 16:35 ` Paul Eggert
2012-08-22 16:50 ` Dmitry Antipov
2012-08-23 7:02 ` Paul Eggert
2012-08-23 12:26 ` Stefan Monnier
2012-08-23 14:40 ` Paul Eggert
2012-08-24 3:46 ` Chong Yidong
2012-08-24 3:57 ` Paul Eggert
2012-08-24 4:26 ` Dmitry Antipov
2012-08-24 15:10 ` Stefan Monnier
2012-08-24 17:19 ` Paul Eggert
2012-08-24 17:27 ` Tom Tromey
2012-08-24 18:11 ` Paul Eggert
2012-08-24 21:12 ` Stefan Monnier
2012-08-25 0:17 ` Paul Eggert
2012-08-25 1:58 ` Stefan Monnier
2012-08-26 5:05 ` Paul Eggert
2012-08-21 17:55 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvk3wrxdqp.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=12215@debbugs.gnu.org \
--cc=dmantipov@yandex.ru \
--cc=eggert@cs.ucla.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.