From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#13866: [VC] =?UTF-8?Q?=E2=80=98vc-git-root=E2=80=99?= is too lax Date: Mon, 04 Mar 2013 09:58:33 -0500 Message-ID: References: <87zjyjijd1.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1362409147 28338 80.91.229.3 (4 Mar 2013 14:59:07 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 4 Mar 2013 14:59:07 +0000 (UTC) Cc: 13866@debbugs.gnu.org To: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Mar 04 15:59:27 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UCWrK-00068V-7E for geb-bug-gnu-emacs@m.gmane.org; Mon, 04 Mar 2013 15:59:22 +0100 Original-Received: from localhost ([::1]:47341 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UCWqy-0003Qp-Sa for geb-bug-gnu-emacs@m.gmane.org; Mon, 04 Mar 2013 09:59:00 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:56657) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UCWqr-0003Qg-Jg for bug-gnu-emacs@gnu.org; Mon, 04 Mar 2013 09:58:58 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UCWqm-0007Jf-WF for bug-gnu-emacs@gnu.org; Mon, 04 Mar 2013 09:58:53 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:54720) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UCWqm-0007Jb-Sj for bug-gnu-emacs@gnu.org; Mon, 04 Mar 2013 09:58:48 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1UCWqz-00077y-LV for bug-gnu-emacs@gnu.org; Mon, 04 Mar 2013 09:59:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Mar 2013 14:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13866 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 13866-submit@debbugs.gnu.org id=B13866.136240913727387 (code B ref 13866); Mon, 04 Mar 2013 14:59:01 +0000 Original-Received: (at 13866) by debbugs.gnu.org; 4 Mar 2013 14:58:57 +0000 Original-Received: from localhost ([127.0.0.1]:58829 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UCWqu-00077f-MW for submit@debbugs.gnu.org; Mon, 04 Mar 2013 09:58:56 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:52003) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UCWqs-00077R-NH for 13866@debbugs.gnu.org; Mon, 04 Mar 2013 09:58:55 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av4EABK/CFFFxLvL/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLNBIUGA2IQgbBLZEKA4hhnBmBXoMV X-IPAS-Result: Av4EABK/CFFFxLvL/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLNBIUGA2IQgbBLZEKA4hhnBmBXoMV X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="2974291" Original-Received: from 69-196-187-203.dsl.teksavvy.com (HELO pastel.home) ([69.196.187.203]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 04 Mar 2013 09:58:32 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id A2E3B6BF75; Mon, 4 Mar 2013 09:58:33 -0500 (EST) In-Reply-To: <87zjyjijd1.fsf@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Mon, 04 Mar 2013 10:50:50 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:72075 Archived-At: > A better definition would be something like this: > (defun vc-git-root (file) > (lexical-let ((root (vc-find-root file ".git"))) > (and (file-in-directory-p root "objects") > root))) Beside the fact that ~/.git is not the config directory, the above code has some problems: vc-git.el uses lexical-binding, so using lexical-let in it is a bad idea. file-in-directory-p sounds completely wrong here. You want to use (file-directory-p (expand-file-name "objects" root)) instead. And of course you could have used simply (vc-find-root file ".git/objects"). Stefan