bug#13992: 24.3; New command compilation-display-error

bug#13992: 24.3; New command compilation-display-error

[Leo Liu]

Hello Stefan,

The attached patch looks like a good addition to compile.el. Bind it to
C-o as in occur-mode. -- Leo

diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el
index 68a83b47..b82afc67 100644
--- a/lisp/progmodes/compile.el
+++ b/lisp/progmodes/compile.el
@@ -1810,6 +1810,7 @@ (defvar compilation-minor-mode-map
     (define-key map [follow-link] 'mouse-face)
     (define-key map "\C-c\C-c" 'compile-goto-error)
     (define-key map "\C-m" 'compile-goto-error)
+    (define-key map "\C-o" 'compilation-display-error)
     (define-key map "\C-c\C-k" 'kill-compilation)
     (define-key map "\M-n" 'compilation-next-error)
     (define-key map "\M-p" 'compilation-previous-error)
@@ -1854,6 +1855,7 @@ (defvar compilation-mode-map
     (define-key map [follow-link] 'mouse-face)
     (define-key map "\C-c\C-c" 'compile-goto-error)
     (define-key map "\C-m" 'compile-goto-error)
+    (define-key map "\C-o" 'compilation-display-error)
     (define-key map "\C-c\C-k" 'kill-compilation)
     (define-key map "\M-n" 'compilation-next-error)
     (define-key map "\M-p" 'compilation-previous-error)
@@ -2295,6 +2297,12 @@ (defun compilation-previous-file (n)
   (interactive "p")
   (compilation-next-file (- n)))
 
+(defun compilation-display-error ()
+  "Display the source for current error in another window."
+  (interactive)
+  (setq compilation-current-error (point))
+  (next-error-no-select 0))
+
 (defun kill-compilation ()
   "Kill the process made by the \\[compile] or \\[grep] commands."
   (interactive)

bug#13992: 24.3; New command compilation-display-error

[Eli Zaretskii]

> From: Leo Liu <sdl.web@gmail.com>
> Date: Mon, 18 Mar 2013 21:00:08 +0800
> 
> The attached patch looks like a good addition to compile.el. Bind it to
> C-o as in occur-mode. -- Leo

Thanks.  The name of the command could have more mnemonic payload,
though.  How about compilation-msg-locus-other-window?

bug#13992: 24.3; New command compilation-display-error

[Stefan Monnier]

> The attached patch looks like a good addition to compile.el.  Bind it to
> C-o as in occur-mode. -- Leo

Fine by me,


        Stefan

bug#13992: 24.3; New command compilation-display-error

[Leo Liu]

On 2013-03-19 01:30 +0800, Eli Zaretskii wrote:
> The name of the command could have more mnemonic payload, though. How
> about compilation-msg-locus-other-window?

The name 'compilation-display-error' is more consistent with how things
are named in compile.el, for example, compile-goto-error. And commands
end with -other-window usually switch you to that window.

Leo

bug#13992: 24.3; New command compilation-display-error

[Leo Liu]

Hi Eli,

I have put the code in trunk. If you have a better name than
compilation-display-error feel free to tweak it ;)

Leo