From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Hit eassert introduced in r110971 Date: Sat, 06 Apr 2013 20:36:35 -0400 Message-ID: References: <51604EBE.1070306@yandex.ru> <83vc7zcxon.fsf@gnu.org> <83sj33cvvx.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1365295014 14396 80.91.229.3 (7 Apr 2013 00:36:54 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 7 Apr 2013 00:36:54 +0000 (UTC) Cc: dmantipov@yandex.ru, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Apr 07 02:36:57 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UOdbL-0008Uc-8u for ged-emacs-devel@m.gmane.org; Sun, 07 Apr 2013 02:36:55 +0200 Original-Received: from localhost ([::1]:52983 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UOdbK-0001tf-RQ for ged-emacs-devel@m.gmane.org; Sat, 06 Apr 2013 20:36:54 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:48938) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UOdbD-0001tV-C7 for emacs-devel@gnu.org; Sat, 06 Apr 2013 20:36:48 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UOdb8-000885-K8 for emacs-devel@gnu.org; Sat, 06 Apr 2013 20:36:47 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:6754) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UOdb2-00086n-Oy; Sat, 06 Apr 2013 20:36:36 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av4EABK/CFFFxLSu/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLNBIUGA0kiB4GwS2RCgOkeoFegxOBSiQ X-IPAS-Result: Av4EABK/CFFFxLSu/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLNBIUGA0kiB4GwS2RCgOkeoFegxOBSiQ X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="6701764" Original-Received: from 69-196-180-174.dsl.teksavvy.com (HELO pastel.home) ([69.196.180.174]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 06 Apr 2013 20:36:32 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 9082362EFF; Sat, 6 Apr 2013 20:36:35 -0400 (EDT) In-Reply-To: <83sj33cvvx.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 06 Apr 2013 22:16:34 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.182 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:158740 Archived-At: > And btw, why do we at all care here about the selected window? > AFAICS, none of the code involved ever changes that. As the comment indicates, this code needs to temporarily change the selected frame, and hence the selected window. > Or, if we do care (maybe some weird code that updates the tool bar can > switch windows?), then simply saving and restoring it would be better > than the assertion. > Stefan, am I missing something? AFAIK, if this assertion fails, it means we have a problem somewhere. Not necessarily in update_tool_bar, but somewhere. OTOH it is a problem that will very rarely cause real trouble once you deactivate the assertion. So what we need to do is to add similar assertions elsewhere to work our way up to the root of the problem. Stefan