* Re: [Emacs-diffs] trunk r116727: Revert last change to w32_read_socket.
[not found] <E1WN5Kj-0003eP-GD@vcs.savannah.gnu.org>
@ 2014-03-10 22:57 ` Stefan Monnier
2014-03-11 8:07 ` martin rudalics
0 siblings, 1 reply; 2+ messages in thread
From: Stefan Monnier @ 2014-03-10 22:57 UTC (permalink / raw)
To: martin rudalics; +Cc: emacs-devel
> Revert last change to w32_read_socket.
When reverting a change, always leave some trace about the reason for
the reversion. E.g. add a comment, or at least a change-log message
pointing to the problem introduced by the code that justified the reversion.
If the reversion is because the original change was simply a pilot error
(never intended to commit it), then the change log should say so. Else,
a comment in the code should explain the problem so that someone else
won't go through the same fruitless change.
Stefan
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [Emacs-diffs] trunk r116727: Revert last change to w32_read_socket.
2014-03-10 22:57 ` [Emacs-diffs] trunk r116727: Revert last change to w32_read_socket Stefan Monnier
@ 2014-03-11 8:07 ` martin rudalics
0 siblings, 0 replies; 2+ messages in thread
From: martin rudalics @ 2014-03-11 8:07 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
> When reverting a change, always leave some trace about the reason for
> the reversion. E.g. add a comment, or at least a change-log message
> pointing to the problem introduced by the code that justified the reversion.
>
> If the reversion is because the original change was simply a pilot error
> (never intended to commit it), then the change log should say so. Else,
> a comment in the code should explain the problem so that someone else
> won't go through the same fruitless change.
I halfheartedly added a comment.
martin
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-03-11 8:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <E1WN5Kj-0003eP-GD@vcs.savannah.gnu.org>
2014-03-10 22:57 ` [Emacs-diffs] trunk r116727: Revert last change to w32_read_socket Stefan Monnier
2014-03-11 8:07 ` martin rudalics
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.