From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] trunk r116727: Revert last change to w32_read_socket. Date: Mon, 10 Mar 2014 18:57:17 -0400 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1394492249 10283 80.91.229.3 (10 Mar 2014 22:57:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 10 Mar 2014 22:57:29 +0000 (UTC) Cc: emacs-devel@gnu.org To: martin rudalics Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Mar 10 23:57:38 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WN98b-0003Q8-I9 for ged-emacs-devel@m.gmane.org; Mon, 10 Mar 2014 23:57:37 +0100 Original-Received: from localhost ([::1]:51543 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WN98b-0005Xo-8d for ged-emacs-devel@m.gmane.org; Mon, 10 Mar 2014 18:57:37 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52018) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WN98R-0005Us-Ed for emacs-devel@gnu.org; Mon, 10 Mar 2014 18:57:34 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WN98K-0001D9-2D for emacs-devel@gnu.org; Mon, 10 Mar 2014 18:57:27 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:65442) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WN98J-0001CT-V6 for emacs-devel@gnu.org; Mon, 10 Mar 2014 18:57:19 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av4EABK/CFFMCppy/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLNBIUGA0kiB4GwS2RCgOfXIUegV6DEw X-IPAS-Result: Av4EABK/CFFMCppy/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLNBIUGA0kiB4GwS2RCgOfXIUegV6DEw X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="51132361" Original-Received: from 76-10-154-114.dsl.teksavvy.com (HELO pastel.home) ([76.10.154.114]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 10 Mar 2014 18:57:17 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 7663B60178; Mon, 10 Mar 2014 18:57:17 -0400 (EDT) In-Reply-To: (Martin Rudalics's message of "Mon, 10 Mar 2014 18:53:53 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:170262 Archived-At: > Revert last change to w32_read_socket. When reverting a change, always leave some trace about the reason for the reversion. E.g. add a comment, or at least a change-log message pointing to the problem introduced by the code that justified the reversion. If the reversion is because the original change was simply a pilot error (never intended to commit it), then the change log should say so. Else, a comment in the code should explain the problem so that someone else won't go through the same fruitless change. Stefan