all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Leo Liu <sdl.web@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] trunk r117274: * emacs-lisp/cl-macs.el (cl-macrolet): Avoid excessive progn's.
Date: Thu, 05 Jun 2014 17:02:29 -0400	[thread overview]
Message-ID: <jwvk38vxebn.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <E1WsbCj-0006W7-Hk@vcs.savannah.gnu.org> (Leo Liu's message of "Thu, 05 Jun 2014 17:11:53 +0000")

> +    (let ((progn-maybe (lambda (body)
> +			 (if (cdr body) (cons 'progn body) (car body)))))

This is called macroexp-progn.

And instead of

   (let ((foo (lambda ...)))
     ... (funcall foo body) ...
     ... (funcall foo body) ...)

better do

   (let ((body-exp ...))
     ... body-exp ...
     ... body-exp ...)


-- Stefan



       reply	other threads:[~2014-06-05 21:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <E1WsbCj-0006W7-Hk@vcs.savannah.gnu.org>
2014-06-05 21:02 ` Stefan Monnier [this message]
2014-06-05 23:03   ` [Emacs-diffs] trunk r117274: * emacs-lisp/cl-macs.el (cl-macrolet): Avoid excessive progn's Leo Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvk38vxebn.fsf-monnier+emacsdiffs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=sdl.web@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.