From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#17813: 24.3.91; bad linum display with `text-scale-adjust' Date: Tue, 08 Jul 2014 15:33:53 -0400 Message-ID: References: <37CF8BE3769E04shigeru.fukaya@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1404942333 31370 80.91.229.3 (9 Jul 2014 21:45:33 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 9 Jul 2014 21:45:33 +0000 (UTC) Cc: 17813@debbugs.gnu.org To: Shigeru Fukaya Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jul 09 23:45:25 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1X4zg5-0000eO-LP for geb-bug-gnu-emacs@m.gmane.org; Wed, 09 Jul 2014 23:45:25 +0200 Original-Received: from localhost ([::1]:33952 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X4zg5-0003k4-BE for geb-bug-gnu-emacs@m.gmane.org; Wed, 09 Jul 2014 17:45:25 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41675) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X4bAU-0000lE-IE for bug-gnu-emacs@gnu.org; Tue, 08 Jul 2014 15:35:18 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X4bAM-0000rg-4a for bug-gnu-emacs@gnu.org; Tue, 08 Jul 2014 15:35:10 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:56145) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X4bAM-0000rc-0I for bug-gnu-emacs@gnu.org; Tue, 08 Jul 2014 15:35:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1X4bAL-0008Sm-JB for bug-gnu-emacs@gnu.org; Tue, 08 Jul 2014 15:35:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Jul 2014 19:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17813 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 17813-submit@debbugs.gnu.org id=B17813.140484805132431 (code B ref 17813); Tue, 08 Jul 2014 19:35:01 +0000 Original-Received: (at 17813) by debbugs.gnu.org; 8 Jul 2014 19:34:11 +0000 Original-Received: from localhost ([127.0.0.1]:47292 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X4b9S-0008Qv-5y for submit@debbugs.gnu.org; Tue, 08 Jul 2014 15:34:11 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:17595) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X4b9L-0008QD-HN for 17813@debbugs.gnu.org; Tue, 08 Jul 2014 15:34:04 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArYGAIDvNVNLd+D9/2dsb2JhbABZgwaDSr0vgw6BFxd0giYBAQRWIxALNBIUGA0kMYdb0hkXjnoHhDgEqRmBaoNMIQ X-IPAS-Result: ArYGAIDvNVNLd+D9/2dsb2JhbABZgwaDSr0vgw6BFxd0giYBAQRWIxALNBIUGA0kMYdb0hkXjnoHhDgEqRmBaoNMIQ X-IronPort-AV: E=Sophos;i="4.97,753,1389762000"; d="scan'208";a="76898621" Original-Received: from 75-119-224-253.dsl.teksavvy.com (HELO pastel.home) ([75.119.224.253]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 08 Jul 2014 15:33:53 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 3851E60337; Tue, 8 Jul 2014 15:33:53 -0400 (EDT) In-Reply-To: <37CF8BE3769E04shigeru.fukaya@gmail.com> (Shigeru Fukaya's message of "Fri, 20 Jun 2014 02:25:28 +0900") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:91346 Archived-At: Version:24.5 > (1) To change the width of left margin for line numbers. > [attached patch] I installed the patch below instead (I earlier used a similar patch for nlinum), which should be slightly more robust. Thank you, Stefan === modified file 'lisp/linum.el' --- lisp/linum.el 2014-02-10 01:34:22 +0000 +++ lisp/linum.el 2014-07-08 19:27:00 +0000 @@ -138,6 +138,9 @@ (mapc #'delete-overlay linum-available) (setq linum-available nil)))) +(defun linum--face-height (face) + (aref (font-info (face-font face)) 2)) + (defun linum-update-window (win) "Update line numbers for the portion visible in window WIN." (goto-char (window-start win)) @@ -178,6 +181,12 @@ (let ((inhibit-point-motion-hooks t)) (forward-line)) (setq line (1+ line))) + (when (display-graphic-p) + (setq width (ceiling + ;; We'd really want to check the widths rather than the + ;; heights, but it's a start. + (/ (* width 1.0 (linum--face-height 'linum)) + (frame-char-height))))) (set-window-margins win width (cdr (window-margins win))))) (defun linum-after-change (beg end _len)