From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Alan Mackenzie <acm@muc.de>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master 05a5a94: Correct calculation of CC Mode's font-lock region.
Date: Mon, 30 Mar 2015 20:40:55 -0400 [thread overview]
Message-ID: <jwvk2xy9f7m.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <20150330224848.GB17661@acm.fritz.box> (Alan Mackenzie's message of "Mon, 30 Mar 2015 22:48:48 +0000")
>> > (c-extend-after-change-region): Explicitly apply 'fontified properties
>> > to the extended bits of the font lock region.
>> Sounds like this is working around a problem elsewhere, so better add
>> a comment explaining what's going on.
> jit-lock-force-redisplay (that function which is set to run on the
> expiry of a 0 second timer, when jit-lock-fontify-now suspects that some
> area which has already been rendered requires to be re-rendered) doesn't
> seem to work. At least, I couldn't get it to work.
That doesn't explain why you need to set the `fontified' property
manually, which is normally done by the code that runs
c-extend-after-change-region (via
font-lock-extend-after-change-region-function).
> f-l-extend-j-l-r-after-change has a recently fixed bug, where the
> extended region is only returned to the caller in certain circumstances.
> Those circumstances no longer hold in CC Mode. To allow CC Mode to
> continue to work in already released Emacs versions, it is necessary to
> set the 'fontified text-property to nil from
> c-extend-after-change-region.
Ah, so that's what's going on. This is the part that needs to be
documented in a comment (and I really mean a comment, not in a ChangeLog).
Stefan
prev parent reply other threads:[~2015-03-31 0:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20150330163859.32247.66180@vcs.savannah.gnu.org>
[not found] ` <E1YcciK-0008Oj-3Q@vcs.savannah.gnu.org>
2015-03-30 21:08 ` [Emacs-diffs] master 05a5a94: Correct calculation of CC Mode's font-lock region Stefan Monnier
2015-03-30 22:48 ` Alan Mackenzie
2015-03-31 0:34 ` Stefan Monnier
2015-03-31 1:47 ` Stefan Monnier
2015-03-31 0:40 ` Stefan Monnier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvk2xy9f7m.fsf-monnier+emacsdiffs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=acm@muc.de \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.