From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#20240: 25.0.50; CC Mode broken fontification and commenting Date: Fri, 03 Apr 2015 18:09:12 -0400 Message-ID: References: <20150403205219.41891.qmail@mail.muc.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1428099028 28164 80.91.229.3 (3 Apr 2015 22:10:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 3 Apr 2015 22:10:28 +0000 (UTC) Cc: Mark Oteiza , 20240@debbugs.gnu.org To: Alan Mackenzie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Apr 04 00:10:17 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Ye9n4-00058f-Ah for geb-bug-gnu-emacs@m.gmane.org; Sat, 04 Apr 2015 00:10:14 +0200 Original-Received: from localhost ([::1]:35669 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ye9n3-0005Hy-Lp for geb-bug-gnu-emacs@m.gmane.org; Fri, 03 Apr 2015 18:10:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42826) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ye9mz-0005Ht-Ax for bug-gnu-emacs@gnu.org; Fri, 03 Apr 2015 18:10:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ye9my-0005zF-Ah for bug-gnu-emacs@gnu.org; Fri, 03 Apr 2015 18:10:09 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:54410) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ye9mt-0005o4-VC; Fri, 03 Apr 2015 18:10:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Ye9ms-0005kv-Ti; Fri, 03 Apr 2015 18:10:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bug-cc-mode@gnu.org Resent-Date: Fri, 03 Apr 2015 22:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20240 X-GNU-PR-Package: emacs,cc-mode X-GNU-PR-Keywords: Original-Received: via spool by 20240-submit@debbugs.gnu.org id=B20240.142809896122066 (code B ref 20240); Fri, 03 Apr 2015 22:10:02 +0000 Original-Received: (at 20240) by debbugs.gnu.org; 3 Apr 2015 22:09:21 +0000 Original-Received: from localhost ([127.0.0.1]:44186 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ye9mC-0005jq-Nb for submit@debbugs.gnu.org; Fri, 03 Apr 2015 18:09:21 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:55786) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ye9mA-0005jc-HJ for 20240@debbugs.gnu.org; Fri, 03 Apr 2015 18:09:19 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AnEFAGvvdVRBbthL/2dsb2JhbAA3gVOfQYIugQiBdgEFViMQCw4mEhQYDSSqJIwhQwwDgz4DEggDg1MEqDs X-IPAS-Result: AnEFAGvvdVRBbthL/2dsb2JhbAA3gVOfQYIugQiBdgEFViMQCw4mEhQYDSSqJIwhQwwDgz4DEggDg1MEqDs X-IronPort-AV: E=Sophos;i="5.01,1,1400040000"; d="scan'208";a="115364731" Original-Received: from 65-110-216-75.cpe.pppoe.ca (HELO pastel.home) ([65.110.216.75]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 03 Apr 2015 18:09:12 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id B157019E0; Fri, 3 Apr 2015 18:09:12 -0400 (EDT) In-Reply-To: <20150403205219.41891.qmail@mail.muc.de> (Alan Mackenzie's message of "3 Apr 2015 20:52:19 -0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:101167 Archived-At: > - (run-hook-with-args 'jit-lock-after-change-extend-region-functions > - start end old-len) > - ;; Make sure we change at least one char (in case of deletions). > - (setq jit-lock-end (min (max jit-lock-end (1+ start)) (point-max))) > - ;; Request refontification. > - (put-text-property jit-lock-start jit-lock-end 'fontified nil)) > + (save-restriction > + (widen) > + (run-hook-with-args 'jit-lock-after-change-extend-region-functions > + start end old-len) > + ;; Make sure we change at least one char (in case of deletions). > + (setq jit-lock-end (min (max jit-lock-end (1+ start)) (point-max))) > + ;; Request refontification. > + (put-text-property jit-lock-start jit-lock-end 'fontified nil))) Widening during the call to jit-lock-after-change-extend-region-functions seems wrong. But I guess there can be meaningful cases where jit-lock-after-change-extend-region-functions could return positions outside of the narrowed region, so I'd be OK with widening during the subsequent `put-text-property'. Stefan