From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Deal gracefully with up-events (Bug#19746) Date: Mon, 10 Aug 2015 17:58:41 -0400 Message-ID: References: <1439215156-26672-1-git-send-email-dak@gnu.org> <1439215156-26672-2-git-send-email-dak@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1439243957 25235 80.91.229.3 (10 Aug 2015 21:59:17 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 10 Aug 2015 21:59:17 +0000 (UTC) Cc: emacs-devel@gnu.org To: David Kastrup Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Aug 10 23:59:01 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZOv5w-00088s-9p for ged-emacs-devel@m.gmane.org; Mon, 10 Aug 2015 23:59:00 +0200 Original-Received: from localhost ([::1]:60300 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZOv5v-0006n6-OV for ged-emacs-devel@m.gmane.org; Mon, 10 Aug 2015 17:58:59 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43145) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZOv5s-0006mn-GW for emacs-devel@gnu.org; Mon, 10 Aug 2015 17:58:57 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZOv5r-0001zX-MR for emacs-devel@gnu.org; Mon, 10 Aug 2015 17:58:56 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:64147) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZOv5m-0001ya-2L; Mon, 10 Aug 2015 17:58:50 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0AyFgA731xV//gFNJ1cgxCEAoVVu0CHSwQCAoE8OhMBAQEBAQEBgQpBBYNdAQEDAVYjBQsLDiYSFBgNJIg3CM8jAQEBAQYBAQEBHos6hQUHhC0FkDSaLYojI2GDMyKCeAEBAQ X-IPAS-Result: A0AyFgA731xV//gFNJ1cgxCEAoVVu0CHSwQCAoE8OhMBAQEBAQEBgQpBBYNdAQEDAVYjBQsLDiYSFBgNJIg3CM8jAQEBAQYBAQEBHos6hQUHhC0FkDSaLYojI2GDMyKCeAEBAQ X-IronPort-AV: E=Sophos;i="5.13,465,1427774400"; d="scan'208";a="159386686" Original-Received: from 157-52-5-248.cpe.teksavvy.com (HELO pastel.home) ([157.52.5.248]) by ironport2-out.teksavvy.com with ESMTP; 10 Aug 2015 17:58:48 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id ED97561783; Mon, 10 Aug 2015 17:58:41 -0400 (EDT) In-Reply-To: <1439215156-26672-2-git-send-email-dak@gnu.org> (David Kastrup's message of "Mon, 10 Aug 2015 15:59:16 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:188712 Archived-At: > * keyboard.c (apply_modifiers_uncached, parse_solitary_modifier) > (parse_modifiers_uncached): React gracefully to "up-" modifiers: > those may easily be injected by user-level Lisp code. > (read_key_sequence): Discard unbound up-events like unbound > down-events: they are even more likely only relevant for special > purposes. Looks good. > While Emacs will not produce up-events on its own currently (those are > converted to drag or click events before being converted to > Lisp-readable structures), the input queue can be made to contain them > by synthesizing events to `unread-command-events'. Emacs should deal > consistently with such events. This probably belongs in a comment rather than in the ChangeLog. Stefan