From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [elpa] master 872014e: Prevent accidental deletion of .git Date: Sun, 08 Nov 2015 20:58:09 -0500 Message-ID: References: <20151109013124.17711.29422@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1447034330 29834 80.91.229.3 (9 Nov 2015 01:58:50 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 9 Nov 2015 01:58:50 +0000 (UTC) Cc: "=?windows-1252?Q?Fabi=E1n?= E. Gallina" , emacs-devel@gnu.org To: Thomas Fitzsimmons Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 09 02:58:40 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZvbjC-00045n-Fi for ged-emacs-devel@m.gmane.org; Mon, 09 Nov 2015 02:58:38 +0100 Original-Received: from localhost ([::1]:49586 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZvbjC-0005kr-Bv for ged-emacs-devel@m.gmane.org; Sun, 08 Nov 2015 20:58:38 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33485) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zvbit-0005iq-P3 for emacs-devel@gnu.org; Sun, 08 Nov 2015 20:58:20 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zvbio-0000pJ-QI for emacs-devel@gnu.org; Sun, 08 Nov 2015 20:58:19 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:56301) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zvbio-0000mv-N4; Sun, 08 Nov 2015 20:58:14 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0AxFgA731xV/6sLr7hcgxCEAoVVu0CHSwQCAoE8OhMBAQEBAQEBgQpBBYNdAQEEViMQCw4mEhQYDSQtiBLPIwEBCAEBAQEeizqEIGUHhC0FjDCnD4FFI4QWIIE0gUQBAQE X-IPAS-Result: A0AxFgA731xV/6sLr7hcgxCEAoVVu0CHSwQCAoE8OhMBAQEBAQEBgQpBBYNdAQEEViMQCw4mEhQYDSQtiBLPIwEBCAEBAQEeizqEIGUHhC0FjDCnD4FFI4QWIIE0gUQBAQE X-IronPort-AV: E=Sophos;i="5.13,465,1427774400"; d="scan'208";a="177561207" Original-Received: from 184-175-11-171.dsl.teksavvy.com (HELO fmsmemgm.homelinux.net) ([184.175.11.171]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 08 Nov 2015 20:58:10 -0500 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id C5639AE250; Sun, 8 Nov 2015 20:58:09 -0500 (EST) In-Reply-To: (Thomas Fitzsimmons's message of "Mon, 09 Nov 2015 01:31:25 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:193670 Archived-At: > +# Use && after the cd commands, not ;, to ensure the build fails > +# immediately if the directory $(ARCHIVE_TMP)/packages does not exist. > +# For process-archive this is crucial; otherwise batch-make-archive in > +# archive-contents.el will interpret directories in the current > +# directory as unreleased packages, and recursively delete them, > +# including .git. Prior to using &&, running "make process-archive" > +# could silently delete all local git history! Actually, I think the problem is in the code which does the deletion: it should only do the delete files it positively knows should be deleted, rather than deleting any files which seem to be out of place. Once we change the handling of :core in elpa/admin/archive-contents.el so that it sets up symlinks rather than performing copies, we should at least be able to make the deletion less dangerous, e.g. by only deleting symlinks and empty directories (so even if the deletion was erroneous, no actual file contents was destroyed along the way). Fabi=E1n, any news on this? Stefan