From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#23006: 25.0.92; Loading Tramp breaks pcomplete in eshell-mode Date: Fri, 18 Mar 2016 12:06:45 -0400 Message-ID: References: <871t7d4ion.fsf@gmx.de> <8737rohoke.fsf@gmx.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1458317243 25285 80.91.229.3 (18 Mar 2016 16:07:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 18 Mar 2016 16:07:23 +0000 (UTC) Cc: 23006@debbugs.gnu.org, Dmitry Gutov To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Mar 18 17:07:12 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1agwve-0005oS-SV for geb-bug-gnu-emacs@m.gmane.org; Fri, 18 Mar 2016 17:07:11 +0100 Original-Received: from localhost ([::1]:44716 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1agwve-0002xD-0k for geb-bug-gnu-emacs@m.gmane.org; Fri, 18 Mar 2016 12:07:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54064) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1agwvZ-0002vN-Om for bug-gnu-emacs@gnu.org; Fri, 18 Mar 2016 12:07:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1agwvW-0007QL-Im for bug-gnu-emacs@gnu.org; Fri, 18 Mar 2016 12:07:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:55699) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1agwvW-0007QH-FE for bug-gnu-emacs@gnu.org; Fri, 18 Mar 2016 12:07:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1agwvW-0004hy-5I for bug-gnu-emacs@gnu.org; Fri, 18 Mar 2016 12:07:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 18 Mar 2016 16:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23006 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23006-submit@debbugs.gnu.org id=B23006.145831721318085 (code B ref 23006); Fri, 18 Mar 2016 16:07:02 +0000 Original-Received: (at 23006) by debbugs.gnu.org; 18 Mar 2016 16:06:53 +0000 Original-Received: from localhost ([127.0.0.1]:52826 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1agwvN-0004hd-Lm for submit@debbugs.gnu.org; Fri, 18 Mar 2016 12:06:53 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:51619) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1agwvL-0004hP-6L for 23006@debbugs.gnu.org; Fri, 18 Mar 2016 12:06:51 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0A2FgA731xV/xSQs2tcgxCEAoVVu0CEfoJNBAICgTw7EgEBAQEBAQGBCkEFg10BAQMBViMFCws0EhQYDSSINwjPIwEBAQEBAQQBAQEBHos6hQUHhC0Fi0STU5IUg1kjgWaCLiKCeAEBAQ X-IPAS-Result: A0A2FgA731xV/xSQs2tcgxCEAoVVu0CEfoJNBAICgTw7EgEBAQEBAQGBCkEFg10BAQMBViMFCws0EhQYDSSINwjPIwEBAQEBAQQBAQEBHos6hQUHhC0Fi0STU5IUg1kjgWaCLiKCeAEBAQ X-IronPort-AV: E=Sophos;i="5.13,465,1427774400"; d="scan'208";a="196673681" Original-Received: from 107-179-144-20.cpe.teksavvy.com (HELO pastel.home) ([107.179.144.20]) by ironport2-out.teksavvy.com with ESMTP; 18 Mar 2016 12:06:45 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 667845FE67; Fri, 18 Mar 2016 12:06:45 -0400 (EDT) In-Reply-To: <8737rohoke.fsf@gmx.de> (Michael Albinus's message of "Thu, 17 Mar 2016 20:49:53 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:115036 Archived-At: > What do you expect (file-name-directory "/davs:") to return else? IIUC "/davs:hello.c" is parsed as a reference to a file on the host "davs" and we nowadays signal an error in that case telling the user to use an explicit "/ssh:davs:hello.c" instead. At least that's how I interpret the tramp-file-name-handler: Host name must not match method "davs" (replace "davs" with "adb" and friends depending on your particular case) we get in the recipe. So, assuming this interpretation is correct, I think "/davs:" should not be considered a valid "directory" name. So I see two options: - (file-name-directory "/davs:") returns "/" - (file-name-directory "/davs:") returns "/davs:" and Tramp accepts (file-name-all-completions "" "/davs:") without signaling an error. > And yes, in this case no trailing slash is added. Hmm, maybe it shall > return "/davs:./". Would this be better? I don't know what are the tradeoffs in this regard, so I have no preference in this regard. But what (file-name-directory "/davs:") returns should be a directory name that file-name-all-completions can use and to the extent that "/davs:" is the prefix of valid file names, file-name-all-completions should not signal an error (it's acceptable if it doesn't actually lists all those valid file names, OTOH). Stefan