all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: 23006@debbugs.gnu.org, Dmitry Gutov <dgutov@yandex.ru>
Subject: bug#23006: 25.0.92; Loading Tramp breaks pcomplete in eshell-mode
Date: Fri, 18 Mar 2016 12:06:45 -0400	[thread overview]
Message-ID: <jwvk2kz93u6.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <8737rohoke.fsf@gmx.de> (Michael Albinus's message of "Thu, 17 Mar 2016 20:49:53 +0100")

> What do you expect (file-name-directory "/davs:") to return else?

IIUC "/davs:hello.c" is parsed as a reference to a file on the host
"davs" and we nowadays signal an error in that case telling the user to
use an explicit "/ssh:davs:hello.c" instead.

At least that's how I interpret the

   tramp-file-name-handler: Host name must not match method "davs"

(replace "davs" with "adb" and friends depending on your particular
case) we get in the recipe.

So, assuming this interpretation is correct, I think "/davs:" should not
be considered a valid "directory" name.

So I see two options:

- (file-name-directory "/davs:") returns "/"
- (file-name-directory "/davs:") returns "/davs:" and Tramp accepts
  (file-name-all-completions "" "/davs:") without signaling an error.

> And yes, in this case no trailing slash is added. Hmm, maybe it shall
> return "/davs:./". Would this be better?

I don't know what are the tradeoffs in this regard, so I have no
preference in this regard.  But what (file-name-directory "/davs:")
returns should be a directory name that file-name-all-completions can
use and to the extent that "/davs:" is the prefix of valid file names,
file-name-all-completions should not signal an error (it's acceptable if
it doesn't actually lists all those valid file names, OTOH).


        Stefan





  reply	other threads:[~2016-03-18 16:06 UTC|newest]

Thread overview: 82+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-14  2:01 bug#23006: 25.0.92; Loading Tramp breaks pcomplete in eshell-mode Dmitry Gutov
2016-03-14  2:22 ` Stefan Monnier
2016-03-14  7:34 ` Michael Albinus
2016-03-15  3:31   ` Stefan Monnier
2016-03-15  8:43     ` Michael Albinus
2016-03-15 11:09       ` Dmitry Gutov
2016-03-17  0:42       ` Stefan Monnier
2016-03-17 19:43         ` Michael Albinus
2016-03-17 19:44           ` Dmitry Gutov
2016-03-17 19:54             ` Michael Albinus
2016-03-17 22:55               ` Dmitry Gutov
2016-03-18  8:27                 ` Michael Albinus
2016-03-18 16:13                   ` Stefan Monnier
2016-03-18 17:01                     ` Michael Albinus
2016-03-18 17:53                       ` Stefan Monnier
2016-03-18 20:21                         ` Michael Albinus
2016-03-18 22:41                           ` Stefan Monnier
2016-03-19  8:28                             ` Michael Albinus
2016-03-19 12:35                               ` Stefan Monnier
2016-03-19 15:28                                 ` Michael Albinus
2016-03-19 20:04                                   ` Stefan Monnier
2016-03-20 15:08                                     ` Michael Albinus
2016-03-20 15:23                                       ` Stefan Monnier
2016-03-20 15:46                                         ` Michael Albinus
2016-03-20 16:10                                           ` Stefan Monnier
2016-03-20 20:40                                             ` Michael Albinus
2016-03-20 22:17                                               ` Stefan Monnier
2016-03-20 22:28                                                 ` Dmitry Gutov
2016-03-21 15:57                                                 ` Michael Albinus
2016-03-20 15:38                                       ` Drew Adams
2016-03-20 15:54                                         ` Michael Albinus
2016-03-20 15:59                                           ` Dmitry Gutov
2016-03-20 20:31                                             ` Michael Albinus
2016-03-20 20:44                                               ` Dmitry Gutov
2016-03-20 20:53                                                 ` Michael Albinus
2016-03-20 21:05                                                   ` Dmitry Gutov
2016-03-20 22:19                                                     ` Stefan Monnier
2016-03-21 15:49                                                       ` Michael Albinus
2016-03-21 19:26                                                         ` Stefan Monnier
2016-03-22  9:27                                                           ` Michael Albinus
2016-03-22 12:02                                                             ` Stefan Monnier
2016-03-22 12:05                                                               ` Michael Albinus
2016-03-22 13:19                                                                 ` Stefan Monnier
2016-03-21 15:46                                                     ` Michael Albinus
2016-03-21 15:49                                                       ` Dmitry Gutov
2016-03-21 16:03                                                         ` Michael Albinus
2016-03-21 16:13                                                           ` Dmitry Gutov
2016-03-21 16:25                                                             ` Michael Albinus
2016-03-21 16:45                                                               ` Dmitry Gutov
2016-03-21 16:55                                                                 ` Michael Albinus
2016-03-21 18:10                                                                   ` Dmitry Gutov
2016-03-21 18:36                                                                     ` Michael Albinus
2016-03-21 21:26                                                                       ` Dmitry Gutov
2016-03-22  9:47                                                                         ` Michael Albinus
2016-03-22 12:05                                                                           ` Stefan Monnier
2016-03-22 12:20                                                                             ` Michael Albinus
2016-03-22 13:37                                                                               ` Stefan Monnier
2016-03-22 13:50                                                                                 ` Michael Albinus
2016-03-22 14:01                                                                                   ` Stefan Monnier
2016-03-24  1:00                                                                           ` Dmitry Gutov
2016-03-21 19:23                                                                   ` Stefan Monnier
2016-03-22  9:25                                                                     ` Michael Albinus
2016-03-22 12:02                                                                       ` Stefan Monnier
2016-03-22 12:08                                                                         ` Michael Albinus
2016-03-22 13:18                                                                           ` Stefan Monnier
2016-03-22 13:35                                                                             ` Michael Albinus
2016-03-22 13:38                                                                               ` Stefan Monnier
2016-03-22 13:50                                                                                 ` Michael Albinus
2016-03-24  0:54                                                                               ` Dmitry Gutov
2016-03-24 13:15                                                                                 ` Stefan Monnier
2016-03-24 13:54                                                                                   ` Dmitry Gutov
2016-03-24 15:56                                                                                     ` Stefan Monnier
2016-03-20 16:38                                           ` Drew Adams
2016-03-20 19:48                                             ` Drew Adams
2016-03-20 20:42                                               ` Michael Albinus
2016-03-18 22:51                         ` Dmitry Gutov
2016-03-17  0:50   ` Stefan Monnier
2016-03-17 19:49     ` Michael Albinus
2016-03-18 16:06       ` Stefan Monnier [this message]
2017-03-09 18:52 ` Michael Albinus
2017-03-15 12:42 ` Michael Albinus
2017-03-17 11:30   ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvk2kz93u6.fsf-monnier+emacsbugs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=23006@debbugs.gnu.org \
    --cc=dgutov@yandex.ru \
    --cc=michael.albinus@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.