From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 3a21ea1: Add more abbrev tests Date: Tue, 03 May 2016 12:54:40 -0400 Message-ID: References: <20160502221340.17892.39911@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1462294550 22183 80.91.229.3 (3 May 2016 16:55:50 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 3 May 2016 16:55:50 +0000 (UTC) Cc: Lee Bochicchio To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue May 03 18:55:34 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1axdba-0003E9-Tc for ged-emacs-devel@m.gmane.org; Tue, 03 May 2016 18:55:27 +0200 Original-Received: from localhost ([::1]:42271 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1axdbW-0007A9-Ua for ged-emacs-devel@m.gmane.org; Tue, 03 May 2016 12:55:22 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56423) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1axdbE-0006xd-I3 for emacs-devel@gnu.org; Tue, 03 May 2016 12:55:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1axdb3-0007oH-06 for emacs-devel@gnu.org; Tue, 03 May 2016 12:54:59 -0400 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:46051) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1axdb2-0007fJ-R4 for emacs-devel@gnu.org; Tue, 03 May 2016 12:54:52 -0400 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id u43Gsene024586; Tue, 3 May 2016 12:54:40 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 74FB9600E9; Tue, 3 May 2016 12:54:40 -0400 (EDT) In-Reply-To: (Lars Ingebrigtsen's message of "Mon, 02 May 2016 22:13:40 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5661=0 X-NAI-Spam-Version: 2.3.0.9418 : core <5661> : inlines <4752> : streams <1629412> : uri <2202452> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:203548 Archived-At: > + (let* ((table (obarray-make))) > + (abbrev-table-put table :abbrev-table-modiff 42) > + (should (abbrev-table-empty-p table)))) AFAIK this is a detail of the implementation, so I'm not sure we want to test it. I'd rather test (should (abbrev-table-empty-p (make-abbrev-table))) -- Stefan