From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#25561: 25.1; "Making isearch-search-fun-function local to *Minibuf-1* while let-bound!" warning with Evil Date: Wed, 08 Feb 2017 17:21:11 -0500 Message-ID: References: <8760kyzoma.fsf@mail.linkov.net> <20170208125523.GA703@odonien.localdomain> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1486592547 12433 195.159.176.226 (8 Feb 2017 22:22:27 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 8 Feb 2017 22:22:27 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: 25561@debbugs.gnu.org, Juri Linkov To: Vasilij Schneidermann Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Feb 08 23:22:23 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cbad0-0002r2-3M for geb-bug-gnu-emacs@m.gmane.org; Wed, 08 Feb 2017 23:22:18 +0100 Original-Received: from localhost ([::1]:33500 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cbad5-0001un-Aw for geb-bug-gnu-emacs@m.gmane.org; Wed, 08 Feb 2017 17:22:23 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54937) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cbacn-0001id-V4 for bug-gnu-emacs@gnu.org; Wed, 08 Feb 2017 17:22:11 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cback-0007uy-OK for bug-gnu-emacs@gnu.org; Wed, 08 Feb 2017 17:22:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:34172) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cback-0007uu-KV for bug-gnu-emacs@gnu.org; Wed, 08 Feb 2017 17:22:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cback-0001t2-EZ for bug-gnu-emacs@gnu.org; Wed, 08 Feb 2017 17:22:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 Feb 2017 22:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25561 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 25561-submit@debbugs.gnu.org id=B25561.14865924767199 (code B ref 25561); Wed, 08 Feb 2017 22:22:02 +0000 Original-Received: (at 25561) by debbugs.gnu.org; 8 Feb 2017 22:21:16 +0000 Original-Received: from localhost ([127.0.0.1]:60604 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cbac0-0001s2-1r for submit@debbugs.gnu.org; Wed, 08 Feb 2017 17:21:16 -0500 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:55532) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cbabw-0001rt-VM for 25561@debbugs.gnu.org; Wed, 08 Feb 2017 17:21:14 -0500 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id v18MLBAE002893; Wed, 8 Feb 2017 17:21:11 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 17EE2600C1; Wed, 8 Feb 2017 17:21:11 -0500 (EST) In-Reply-To: <20170208125523.GA703@odonien.localdomain> (Vasilij Schneidermann's message of "Wed, 8 Feb 2017 13:55:23 +0100") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV5943=0 X-NAI-Spam-Version: 2.3.0.9418 : core <5943> : inlines <5682> : streams <1732088> : uri <2373886> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:129135 Archived-At: >> > a user of the Evil package reported [1] that using a search command >> > results in a "Making isearch-search-fun-function local to *Minibuf-1* >> > while let-bound!" warning. This appears to be an interaction between >> > isearch and Evil, more specifically, Evil let-binds >> > `isearch-search-fun-function' to something of its own, invokes isearch >> > and something in isearch ends up running >> > `minibuffer-history-isearch-setup' which `make-local-variable' to have >> > `isearch-search-fun-function' have a separate value, resulting in the >> > aforementioned warning. >> > >> > What's the recommended way to avoid or silence it? Stefan suggested >> > elsewhere [2] that this might indicate a bug, hence why I'm bringing >> > this up here. I plead guilty of adding this warning. But FWIW, I think it was misguided: the interaction between make-local-variable and let-binding can be pretty tricky, which is why I added the warning (thinking that such things should better be avoided), but in my subsequent experience, I haven't found a single case where the problem is real. Worse: it's often difficult/ugly to change the code to avoid the "tricky" interaction, because the code that does the let-binding doesn't know about the other and vice-versa. So, while the trickiness rmains, I think it's best to just hope for the best, silently, rather than signal a warning that nobody (not even me) knows how to address satisfactorily. Stefan