From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 5f72004: Revert "Fix command repetition with lexical-binding (Bug#29334)" Date: Tue, 09 Jan 2018 08:11:23 -0500 Message-ID: References: <20180107024858.4583.97855@vcs0.savannah.gnu.org> <20180107024859.76DAA2020F@vcs0.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1515503386 5434 195.159.176.226 (9 Jan 2018 13:09:46 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 9 Jan 2018 13:09:46 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Emacs developers To: Noam Postavsky Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jan 09 14:09:41 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eYtep-0000gw-7B for ged-emacs-devel@m.gmane.org; Tue, 09 Jan 2018 14:09:35 +0100 Original-Received: from localhost ([::1]:51955 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eYtgm-0006mN-UG for ged-emacs-devel@m.gmane.org; Tue, 09 Jan 2018 08:11:36 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42813) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eYtgd-0006ks-Pi for emacs-devel@gnu.org; Tue, 09 Jan 2018 08:11:28 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eYtga-0000oh-Kc for emacs-devel@gnu.org; Tue, 09 Jan 2018 08:11:27 -0500 Original-Received: from pmta31.teksavvy.com ([76.10.157.38]:17122) by eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71) (envelope-from ) id 1eYtga-0000nP-EN for emacs-devel@gnu.org; Tue, 09 Jan 2018 08:11:24 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2EvHgA5vlRa/yyKSC1dHQEBBQELAYNAg?= =?us-ascii?q?VqDbYpWjnWCAplDhUUChDlCFQEBAQEBAQEBAQNoKIUlAQQBeQULCw0BJhIUGDG?= =?us-ascii?q?KPAixPSECiiEBAQEBBgIBJYQgghWGbosaBZM6kCWhTyiHUxOYQjUkgVAyGggwg?= =?us-ascii?q?miDCIFsI4s1AQEB?= X-IPAS-Result: =?us-ascii?q?A2EvHgA5vlRa/yyKSC1dHQEBBQELAYNAgVqDbYpWjnWCApl?= =?us-ascii?q?DhUUChDlCFQEBAQEBAQEBAQNoKIUlAQQBeQULCw0BJhIUGDGKPAixPSECiiEBA?= =?us-ascii?q?QEBBgIBJYQgghWGbosaBZM6kCWhTyiHUxOYQjUkgVAyGggwgmiDCIFsI4s1AQE?= =?us-ascii?q?B?= X-IronPort-AV: E=Sophos;i="5.46,335,1511845200"; d="scan'208";a="17111720" Original-Received: from unknown (HELO pastel.home) ([45.72.138.44]) by smtp.teksavvy.com with ESMTP; 09 Jan 2018 08:11:23 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 6DCB960819; Tue, 9 Jan 2018 08:11:23 -0500 (EST) In-Reply-To: (Noam Postavsky's message of "Mon, 8 Jan 2018 21:32:00 -0500") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 76.10.157.38 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:221757 Archived-At: > Hmm, I just reverted to the previous code without actually thinking > about it. But after checking this more closely, I find that passing > non-nil LEXICAL to `eval' doesn't really do anything for compiled > functions anyway: the "lexicalness" has already been applied when > compiling. E.g., the above change has no effect on the attached tests. If the interactive spec has been compiled (as was always the case until now), then indeed it shouldn't make a difference. But if the byte-code object was built by hand (or with the change you intended to install) the interactive spec could be non-compiled, in which case the LEXICAL arg to `eval` can have an effect. So yes, it's not super important, but I think this part of your patch should not have been reverted. Stefan