Re: master a12dccc 3/3: Add more build outputs to .gitignore

Re: master a12dccc 3/3: Add more build outputs to .gitignore

[Glenn Morris]

Hi, a lot of this change looks iffy:

Daniel Colascione wrote:

> commit a12dccc713c3de1c1069ea6b4c173a789bd4a45c

>     * .gitignore: Add more generated files

> +# Miscellaneous build stuf
> +build-aux/

What generated files did you find in build-aux?

> +lib/.deps
> +src/stamp-h.in
> +src/stamp-h1

The src/stamp stuff should not be needed for ~ the past year, since
http://lists.gnu.org/archive/html/emacs-diffs/2017-03/msg00180.html

Maybe you had some very old, stale build files left over in your tree
from a long time ago?

Re: [Emacs-diffs] master a12dccc 3/3: Add more build outputs to .gitignore

[Stefan Monnier]

> +# Miscellaneous build stuf
> +build-aux/
[...]
> +lib/.deps
> +src/stamp-h.in
> +src/stamp-h1

Does our build still generate these?


        Stefan

Re: [Emacs-diffs] master a12dccc 3/3: Add more build outputs to .gitignore

[Daniel Colascione]

On 02/23/2018 06:44 AM, Stefan Monnier wrote:
>> +# Miscellaneous build stuf
>> +build-aux/
> [...]
>> +lib/.deps
>> +src/stamp-h.in
>> +src/stamp-h1
> 
> Does our build still generate these?
>

I saw them in my build, but it's fully possible that I just didn't 
notice that they were stale. I'd been doing most of my work in my 
pdumper working directory, not the Emacs trunk one. Feel free to revert 
the .gitignore change if it's actually bogus.

Re: [Emacs-diffs] master a12dccc 3/3: Add more build outputs to .gitignore

[Paul Eggert]

Yes, this was almost surely just a stale-build issue. I reverted the 
.gitignore change.

Re: [Emacs-diffs] master a12dccc 3/3: Add more build outputs to .gitignore

[Daniel Colascione]

On 02/23/2018 11:59 AM, Paul Eggert wrote:
> Yes, this was almost surely just a stale-build issue. I reverted the 
> .gitignore change.

Thanks