From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Noam Postavsky <npostavs@gmail.com>
Cc: 12747@debbugs.gnu.org, Oleksandr Gavenko <gavenkoa@gmail.com>
Subject: bug#12747: 23.4; diff-auto-refine-mode process only last hunk in diff (must ALL).
Date: Thu, 12 Jul 2018 16:17:18 -0400 [thread overview]
Message-ID: <jwvk1q043kh.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <CAM-tV-_fCgmNnjo6oJfbcUhyehy+wZibivaYidkTQy99hktmmw@mail.gmail.com> (Noam Postavsky's message of "Thu, 12 Jul 2018 15:54:42 -0400")
>>> This reminds that magit users found binding write-region-inhibit-fsync
>>> around smerge-refine-regions made a noticable performance difference.
>>> So should we add something like this?
>> Sounds good, yes (tho I'm surprised it'd make much of a difference,
>> when your /tmp is on some kind of tmpfs). If you can add a URL
>> pointing to the discussion where they found the noticable performance
>> difference, that'd be even better.
> Hmm, actually there wasn't that much discussion about it, one person
> reported it made a big difference:
> https://github.com/magit/magit/pull/2834
Seems like a good enough URL top put there.
IIUC magit's code uses a different approach from the one I installed in
diff-mode (i.e. it eagerly calls smerge-refine on all hunks), which
is likely to suffer much more severely from performance issues on large
diffs, so I think write-region-inhibit-fsync won't make a big difference
for diff-mode, but it's still a good change in any case.
Note that both approaches suffer identically when bumping into a large
hunk, OTOH.
> There was previous discussion about smerge refinement being slow, but
> nobody narrowed it down to fsync in particular, and the conclusion
> there was just "call smerge-refine-subst less".
Yes, I think this one is really case of Magit's approach being simply
too eager.
Stefan
next prev parent reply other threads:[~2018-07-12 20:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-28 12:13 bug#12747: 23.4; diff-auto-refine-mode process only last hunk in diff (must ALL) Oleksandr Gavenko
2012-10-28 13:54 ` Stefan Monnier
2012-10-28 19:38 ` Oleksandr Gavenko
2012-10-28 20:29 ` Stefan Monnier
2018-07-12 0:28 ` Noam Postavsky
2018-07-12 13:28 ` Stefan Monnier
2018-07-12 19:54 ` Noam Postavsky
2018-07-12 20:17 ` Stefan Monnier [this message]
2018-07-13 1:47 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvk1q043kh.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=12747@debbugs.gnu.org \
--cc=gavenkoa@gmail.com \
--cc=npostavs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.