all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master 7b31de4: Add hook for all events
Date: Wed, 23 Jan 2019 21:06:14 -0500	[thread overview]
Message-ID: <jwvk1iu24sz.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: 87fttj55t8.fsf@russet.org.uk

> Short answer: input methods break completion provided by both company
> and my own pabbrev. For example, try copying the company-mode
> documentation into *scratch*, M-x text-mode, M-x company-mode, M-x
> set-input-method "italian-postfix". Now type "Comple". You should see
> something like:
>
> Compl
> Complements
> Complete
> Completing
> Completion
> Complex
> e_[]
>
> where e_ is e underscore and [] is the cursor and the lines in the
> middle are offered completions.
>
> The problem is that company uses pre-command-hook to remove old offered
> completions. But self-insert hasn't run yet, because the user hasn't
> decided whether to type "e" or "e'". With this hook, I can pick up the
> intermediate keypresses.

So, IIUC the issue is to detect when to pop down the completions offered
by the likes of company/pabbrev/...
And the idea is that those packages can stop using pre-command-hook and
use input-event-functions.

So, IIUC now company will pop down its menu as soon as you hit a prefix
key like C-x or C-c, right?  Is that a desirable or undesirable
side-effect?

I guess the previously available alternative was to use sit-for to wait
for the next event, right (and indeed, I think input-event-functions is
a better option than sit-for)?


        Stefan




  reply	other threads:[~2019-01-24  2:06 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20190122214637.25164.20429@vcs0.savannah.gnu.org>
     [not found] ` <20190122214639.B2E13203DD@vcs0.savannah.gnu.org>
2019-01-22 23:17   ` master 7b31de4: Add hook for all events Michael Albinus
2019-01-23 22:56     ` Phillip Lord
2019-01-24  3:36       ` Eli Zaretskii
2019-01-23  1:30   ` [Emacs-diffs] " Daniel Colascione
2019-01-23 23:10     ` Phillip Lord
2019-01-24  2:06       ` Stefan Monnier [this message]
2019-01-24 10:41         ` Phillip Lord
2019-01-25 13:56           ` Stefan Monnier
2019-01-28  9:42             ` Phillip Lord
2019-01-26  0:50           ` Stefan Monnier
2019-01-28  9:54             ` Phillip Lord
2019-02-02 16:13               ` Timing of input-method output (was: [Emacs-diffs] master 7b31de4: Add hook for all events) Stefan Monnier
2019-02-03 22:06                 ` Timing of input-method output Phillip Lord
2019-02-05 14:49                   ` Stefan Monnier
2019-02-06 22:18                     ` Phillip Lord
2019-02-06 22:55                       ` Stefan Monnier
2019-02-11 22:10                         ` Phillip Lord
2019-02-11 22:20                           ` Stefan Monnier
2019-02-12 12:21                             ` Phillip Lord
2019-03-25 21:48                               ` Phillip Lord
2019-03-26 15:12                                 ` Stefan Monnier
2019-03-28 13:54                                   ` Phillip Lord

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvk1iu24sz.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.