all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: Nathan Trapuzzano <nbtrap@nbtrap.com>, 17127@debbugs.gnu.org
Subject: bug#17127: `call-process' circumvents password concealment w/ `read-passwd'
Date: Wed, 23 Oct 2019 18:01:45 -0400	[thread overview]
Message-ID: <jwvk18vjf9z.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87y2y7gogl.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 29 Sep 2019 16:35:22 +0200")

> The following patch fixes this, I think, by using post-command-hook
> instead of after-change-functions.

Actually, in theory after-change-functions should catch all cases
whereas post-command-hook might miss some (i.e. chars inserted not
while running a command, e.g. from a process filter).

So while your new code probably works fine in practice (and is a good
workaround for now) , I think the original code is "more correct" and we
should try and figure out why it didn't work: how come
after-change-functions is not run (or not correctly) by call-process?


        Stefan






  parent reply	other threads:[~2019-10-23 22:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-28  0:32 bug#17127: `call-process' circumvents password concealment w/ `read-passwd' Nathan Trapuzzano
2014-03-28  2:04 ` Stefan Monnier
2014-03-28  2:39   ` Nathan Trapuzzano
2019-09-29 14:35 ` Lars Ingebrigtsen
2019-10-13  3:16   ` Lars Ingebrigtsen
2019-10-23 22:01   ` Stefan Monnier [this message]
2019-10-24 11:49     ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvk18vjf9z.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=17127@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    --cc=nbtrap@nbtrap.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.