From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#14120: [Robert Weiner] Emacs history selection non-string arguments causing failures for a long time Date: Sun, 16 Feb 2020 20:52:32 -0500 Message-ID: References: <87fvz9rhqq.fsf@olor.terpri.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="5579"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 14120@debbugs.gnu.org To: Robert Weiner Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Feb 17 02:53:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j3Vax-0001Jl-1E for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 17 Feb 2020 02:53:11 +0100 Original-Received: from localhost ([::1]:39132 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j3Vav-00056x-Ni for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 16 Feb 2020 20:53:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39831) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j3Vao-00056m-Th for bug-gnu-emacs@gnu.org; Sun, 16 Feb 2020 20:53:03 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j3Van-00029S-RH for bug-gnu-emacs@gnu.org; Sun, 16 Feb 2020 20:53:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60147) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j3Van-00029B-Oa for bug-gnu-emacs@gnu.org; Sun, 16 Feb 2020 20:53:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j3Van-0006B7-MB for bug-gnu-emacs@gnu.org; Sun, 16 Feb 2020 20:53:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 17 Feb 2020 01:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14120 X-GNU-PR-Package: emacs Original-Received: via spool by 14120-submit@debbugs.gnu.org id=B14120.158190437323732 (code B ref 14120); Mon, 17 Feb 2020 01:53:01 +0000 Original-Received: (at 14120) by debbugs.gnu.org; 17 Feb 2020 01:52:53 +0000 Original-Received: from localhost ([127.0.0.1]:37887 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j3Vaf-0006Ai-6C for submit@debbugs.gnu.org; Sun, 16 Feb 2020 20:52:53 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:2865) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j3Vae-0006AX-8y for 14120@debbugs.gnu.org; Sun, 16 Feb 2020 20:52:52 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id BFC5B10075B; Sun, 16 Feb 2020 20:52:46 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 4F3BF1003E2; Sun, 16 Feb 2020 20:52:44 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1581904364; bh=H+i8zI41i8pY5EsH9jHB3PUujahIUwyHrRvg6FvmD0s=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=S/11C0ozExmkZ3qiv+aVUXOm3sv+i53bcrZH7A6Csn8UYfxHdjPpE/u8mi2hSYLDW JUmHx2/pDgv7Y+BaECA1azmVzWbz9N47Zv52SmjwY3SVAMzfjoAWviZAe0FAAv2l2t irA9GbF86hzsk40pqtzWKIadPG3XbufoRPpkzL2gkq1oH8Ehbiu761Es08/53iC40g XR/GtbsTn65VAv5fQIZQEajKOjDG+/MKNKX3Bo/uT1+d29RxyAGWP2ewDbj2YVG5f2 4kIG29CDyiJ3KPwfvHmSggBMXK+OsUh6rsvswRuXkJvknuTlKl1fB34Whi+TKWZkRE 33GURFj6dPt/g== Original-Received: from ceviche (unknown [157.52.14.222]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id A1BDA1204F0; Sun, 16 Feb 2020 20:52:43 -0500 (EST) In-Reply-To: (Stefan Monnier's message of "Sun, 16 Feb 2020 15:55:12 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:176130 Archived-At: > This bug #14120 in subr.el is still occurring in Emacs 27.0.50 because > leading entries like (require . info) rather than strings are being > injected into the history. Since this has affected people for quite a > while, I hope you or someone else can add this one line change to the Emacs > 27 branch and resolve it. The original #14120 report was linked to the use of CANNOT_DUMP which is not used any more, AFAICT, so we haven't really investigated this bug. Concretely, I don't know how/where this shows up. Do you have some recipe (and/or backtrace)? > ! ;; https://debbugs.gnu.org/cgi/bugreport.cgi?bug=14120 > ! ;; Avoid this bug still occuring in Emacs 27.0.50 by checking > ! ;; if load-elt is a string or not. > ! (or (not (stringp (car load-elt))) > (not (string-match file-regexp (car load-elt))))) The docstring of `load-history` says that (car load-elt) should never be anything else than a string or nil. So the right fix is likely elsewhere. Stefan